]> granicus.if.org Git - php/commitdiff
clean up - remove checked questions
authorXinchen Hui <laruence@php.net>
Wed, 13 Aug 2014 08:44:22 +0000 (16:44 +0800)
committerXinchen Hui <laruence@php.net>
Wed, 13 Aug 2014 08:44:22 +0000 (16:44 +0800)
ext/mysql/php_mysql.c
ext/session/session.c
ext/sqlite3/sqlite3.c

index 30cac98b6560a05bea5fbfe87b515ef11ebb79e0..f4124d306bc9d7afc37813078fdb81760e8cb4df 100644 (file)
@@ -641,10 +641,9 @@ PHP_RINIT_FUNCTION(mysql)
 /* }}} */
 
 #if defined(A0) && defined(MYSQL_USE_MYSQLND)
-static int php_mysql_persistent_helper(zval *el;zend_rsrc_list_entry *le TSRMLS_DC)
+static int php_mysql_persistent_helper(zval *el TSRMLS_DC)
 {
-       //???
-       //zend_rsrc_list_entry *le = (zend_rsrc_list_entry*)Z_PTR_P(el);
+       zend_resource *le = (zend_resource *)Z_PTR_P(el);
        if (le->type == le_plink) {
                mysqlnd_end_psession(((php_mysql_conn *) le->ptr)->conn);
        }
index 46ffa566c8dfb1840703274bba0208be85ef7601..3dc47f6a76979cc3a704873a1bde4bcd57729cdf 100644 (file)
@@ -1935,8 +1935,8 @@ static PHP_FUNCTION(session_id)
        }
 
        if (PS(id)) {
-               //??? keep compatibility for "\0" characters
-               //??? see: ext/session/tests/session_id_error3.phpt
+               /* keep compatibility for "\0" characters
+               / see: ext/session/tests/session_id_error3.phpt */
                int len = strlen(PS(id)->val);
                if (UNEXPECTED(len != PS(id)->len)) {
                        RETVAL_STR(STR_INIT(PS(id)->val, len, 0));
index 1d3c612f6a7d2645d6a920c35de0c3901cdbf1b3..54c80972c941ec339a0166b4e467adac961ec29e 100644 (file)
@@ -2002,7 +2002,6 @@ static void php_sqlite3_free_list_dtor(void **item)
 
 static int php_sqlite3_compare_stmt_zval_free(php_sqlite3_free_list **free_list, zval *statement ) /* {{{ */
 {
-       //?????  return ((*free_list)->stmt_obj->initialised && statement == (*free_list)->stmt_obj_zval);
        return  ((*free_list)->stmt_obj->initialised && Z_PTR_P(statement) == Z_PTR((*free_list)->stmt_obj_zval));      
 }
 /* }}} */