Issue 8436: set.__init__ accepts keyword args

diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
index b28022be49df07ba6bb037654538450a1d2a0836..0c29017a808ac98c9dced34a710f8f6d203134c8 100644 (file)
--- a/Lib/test/test_set.py
+++ b/Lib/test/test_set.py
@@ -1,3 +1,4 @@
+
 import unittest
 from test import test_support
 import gc
@@ -47,6 +48,7 @@ class TestJointOps(unittest.TestCase):
 
     def test_new_or_init(self):
         self.assertRaises(TypeError, self.thetype, [], 2)
+        self.assertRaises(TypeError, set().__init__, a=1)
 
     def test_uniquification(self):
         actual = sorted(self.s)

diff --git a/Objects/setobject.c b/Objects/setobject.c
index ab281af3f5b09a8f26ff480587a6795415180a9b..f97b0c02f4df0f51ee4ac031099182ac25869e3c 100644 (file)
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -1987,6 +1987,8 @@ set_init(PySetObject *self, PyObject *args, PyObject *kwds)
 
        if (!PyAnySet_Check(self))
                return -1;
+       if (PySet_Check(self) && !_PyArg_NoKeywords("set()", kwds))
+               return -1;
        if (!PyArg_UnpackTuple(args, Py_TYPE(self)->tp_name, 0, 1, &iterable))
                return -1;
        set_clear_internal(self);