]> granicus.if.org Git - python/commitdiff
Speed-up building enums by value, e.g. http.HTTPStatus(200) (#11318)
authorAndrew Svetlov <andrew.svetlov@gmail.com>
Wed, 26 Dec 2018 18:45:33 +0000 (20:45 +0200)
committerEthan Furman <ethan@stoneleaf.us>
Wed, 26 Dec 2018 18:45:33 +0000 (10:45 -0800)
bpo-35585: Speed up enum by-value lookup

Lib/enum.py
Misc/NEWS.d/next/Library/2018-12-26-02-28-00.bpo-35585.Lkzd3Z.rst [new file with mode: 0644]

index fec1aed9b25c111b080282efc96ac4ad9f21be1a..f7452f0cc0aaa54a73aa98be2d4d6135d0035d32 100644 (file)
@@ -563,8 +563,10 @@ class Enum(metaclass=EnumMeta):
         # by-value search for a matching enum member
         # see if it's in the reverse mapping (for hashable values)
         try:
-            if value in cls._value2member_map_:
-                return cls._value2member_map_[value]
+            return cls._value2member_map_[value]
+        except KeyError:
+            # Not found, no need to do long O(n) search
+            pass
         except TypeError:
             # not there, now do long search -- O(n) behavior
             for member in cls._member_map_.values():
diff --git a/Misc/NEWS.d/next/Library/2018-12-26-02-28-00.bpo-35585.Lkzd3Z.rst b/Misc/NEWS.d/next/Library/2018-12-26-02-28-00.bpo-35585.Lkzd3Z.rst
new file mode 100644 (file)
index 0000000..247a4ae
--- /dev/null
@@ -0,0 +1 @@
+Speed-up building enums by value, e.g. http.HTTPStatus(200).