FIXME400

diff --git a/modules/tinydnsbackend/tinydnsbackend.cc b/modules/tinydnsbackend/tinydnsbackend.cc
index 4425d3005871070770659db3979bb6fa23560fb1..e223521146e8429697adfe7ed434e3e77c5683c6 100644 (file)
--- a/modules/tinydnsbackend/tinydnsbackend.cc
+++ b/modules/tinydnsbackend/tinydnsbackend.cc
@@ -157,7 +157,7 @@ void TinyDNSBackend::getAllDomains(vector<DomainInfo> *domains, bool include_dis
 
 bool TinyDNSBackend::list(const DNSName &target, int domain_id, bool include_disabled) {
        d_isAxfr=true;
-       string key = target.toDNSString(); // FIXME bug: no lowercase here? or promise that from core?
+       string key = target.toDNSString(); // FIXME400 bug: no lowercase here? or promise that from core?
        d_cdbReader=new CDB(getArg("dbfile"));
        return d_cdbReader->searchSuffix(key);
 }

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index deea1c1a6c0245d17411463df5bbcc6b30a6c955..d3f2e3f6e39d10bef05c959580c402b415d45985 100644 (file)
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -1243,7 +1243,7 @@ bool GSQLBackend::feedRecord(const DNSResourceRecord &r, string *ordername)
         bind("qtype",r.qtype.getName())->
         bind("domain_id",r.domain_id)->
         bind("disabled",r.disabled)->
-        bind("qname",stripDot(r.qname.toString())); // FIXME lowercase?
+        bind("qname",stripDot(r.qname.toString())); // FIXME400 lowercase?
         if (ordername == NULL)
           d_InsertRecordOrderQuery_stmt->bindNull("ordername");
         else 

diff --git a/pdns/backends/gsql/ssql.hh b/pdns/backends/gsql/ssql.hh
index 7a21c27cba100b43c03374a3e799b4a6f07018b9..293b2dce2416a09f80832d7a0f5db390fe2944ce 100644 (file)
--- a/pdns/backends/gsql/ssql.hh
+++ b/pdns/backends/gsql/ssql.hh
@@ -47,7 +47,7 @@ public:
   virtual SSqlStatement* bind(const string& name, unsigned long long value)=0;
   virtual SSqlStatement* bind(const string& name, const std::string& value)=0;
   SSqlStatement* bind(const string& name, const DNSName& value) {
-    return bind(name, toLower(value.toStringNoDot())); // FIXME toLower()?
+    return bind(name, toLower(value.toStringNoDot())); // FIXME400 toLower()?
   }
   virtual SSqlStatement* bindNull(const string& name)=0;
   virtual SSqlStatement* execute()=0;;

diff --git a/pdns/dns.hh b/pdns/dns.hh
index 2c0b763e62fb8682c9d69198693d5c72f578fbc9..0821d05e0abc90e5937e6297220995c100e549a5 100644 (file)
--- a/pdns/dns.hh
+++ b/pdns/dns.hh
@@ -34,7 +34,7 @@
 #include <time.h>
 #include <sys/types.h>
 class DNSBackend;
-class DNSName; // FIXME
+class DNSName; // FIXME400
 
 struct SOAData
 {

diff --git a/pdns/dnsbackend.cc b/pdns/dnsbackend.cc
index f03d1092f7e3972bdda4632bcf58739cdf7bac91..f0353163a651b6e1b221dd0b945b44ea78a1343e 100644 (file)
--- a/pdns/dnsbackend.cc
+++ b/pdns/dnsbackend.cc
@@ -255,7 +255,7 @@ bool DNSBackend::getSOA(const DNSName &domain, SOAData &sd, DNSPacket *p)
   if(!sd.hostmaster.countLabels()) {
     if (!arg().isEmpty("default-soa-mail")) {
       sd.hostmaster=arg()["default-soa-mail"];
-      // attodot(sd.hostmaster); FIXME
+      // attodot(sd.hostmaster); FIXME400
     }
     else
       sd.hostmaster=DNSName("hostmaster")+domain;
@@ -279,9 +279,9 @@ bool DNSBackend::getSOA(const DNSName &domain, SOAData &sd, DNSPacket *p)
 
 bool DNSBackend::getBeforeAndAfterNames(uint32_t id, const DNSName& zonename, const DNSName& qname, DNSName& before, DNSName& after)
 {
-  // FIXME FIXME FIXME
-  // string lcqname=toLower(qname); FIXME tolower?
-  // string lczonename=toLower(zonename); FIXME tolower?
+  // FIXME400 FIXME400 FIXME400
+  // string lcqname=toLower(qname); FIXME400 tolower?
+  // string lczonename=toLower(zonename); FIXME400 tolower?
   // lcqname=makeRelative(lcqname, lczonename);
   DNSName lczonename = DNSName(toLower(zonename.toString()));
   // lcqname=labelReverse(lcqname);
@@ -294,8 +294,8 @@ bool DNSBackend::getBeforeAndAfterNames(uint32_t id, const DNSName& zonename, co
   before = DNSName(labelReverse(sbefore)) + lczonename;
   after = DNSName(labelReverse(safter)) + lczonename;
 
-  // before=dotConcat(labelReverse(before), lczonename); FIXME
-  // after=dotConcat(labelReverse(after), lczonename); FIXME
+  // before=dotConcat(labelReverse(before), lczonename); FIXME400
+  // after=dotConcat(labelReverse(after), lczonename); FIXME400
   return ret;
 }
 

diff --git a/pdns/dnslabeltext.rl b/pdns/dnslabeltext.rl
index 2f628376fd102d1aeff8845c8a11b9726974f20d..300c2022de19345556b5f68868fb1d5b3a654391 100644 (file)
--- a/pdns/dnslabeltext.rl
+++ b/pdns/dnslabeltext.rl
@@ -97,7 +97,7 @@ deque<string> segmentDNSName(const string& input )
         string realinput;
         if(input.empty() || input == ".") return ret;
 
-        if(input[input.size()-1]!='.') realinput=input+".";  // FIXME YOLO
+        if(input[input.size()-1]!='.') realinput=input+".";  // FIXME400 YOLO
         else realinput=input;
 
         const char *p = realinput.c_str(), *pe = realinput.c_str() + realinput.length();

diff --git a/pdns/dnsname.cc b/pdns/dnsname.cc
index f6191149f4b6aceb39a5ed2f17f70c82a3ed2c20..8e953db864174036cd00b6c314709c62c7e6a549 100644 (file)
--- a/pdns/dnsname.cc
+++ b/pdns/dnsname.cc
@@ -241,7 +241,7 @@ bool DNSName::operator==(const DNSName& rhs) const
 size_t hash_value(DNSName const& d)
 {
   boost::hash<string> hasher;
-  return hasher(toLower(d.toString())); // FIXME HACK
+  return hasher(toLower(d.toString())); // FIXME400 HACK
 }
 
 string DNSName::escapeLabel(const std::string& label)

diff --git a/pdns/dnsname.hh b/pdns/dnsname.hh
index f3dc15c3bce58220816bc33595756ff8686d204a..8be308a2426f4ef8ded40695df16ef72914889b3 100644 (file)
--- a/pdns/dnsname.hh
+++ b/pdns/dnsname.hh
@@ -46,7 +46,7 @@ public:
   DNSName labelReverse() const;
   bool isWildcard() const;
   unsigned int countLabels() const;
-  size_t length() const; // FIXME remove me?
+  size_t length() const; // FIXME400 remove me?
   bool empty() const { return d_empty; }
   bool isRoot() const { return !d_empty && d_storage.empty(); }
   void clear() { d_storage.clear(); d_empty=true; }

diff --git a/pdns/dnspacket.cc b/pdns/dnspacket.cc
index a0cd86e8c3b9263ba385a5564a061c9fb1fafcfe..e5c90e0c36bcba42f6d9f27b16afc7c0b3df74fd 100644 (file)
--- a/pdns/dnspacket.cc
+++ b/pdns/dnspacket.cc
@@ -633,7 +633,7 @@ bool checkForCorrectTSIG(const DNSPacket* q, UeberBackend* B, DNSName* keyname,
     return false;
   }
 
-  DNSName algoName = trc->d_algoName; // FIXME
+  DNSName algoName = trc->d_algoName; // FIXME400
   if (algoName == "hmac-md5.sig-alg.reg.int")
     algoName = "hmac-md5";
 

diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
index a02cc45f81e2295a9ae43b88ff7df5b602a42685..c445ce46b7b5a929838e77372305fad5006c83f5 100644 (file)
--- a/pdns/dnsparser.cc
+++ b/pdns/dnsparser.cc
@@ -80,7 +80,7 @@ private:
   vector<uint8_t> d_record;
 };
 
-//FIXME lots of overlap with DNSPacketWriter::xfrName
+//FIXME400 lots of overlap with DNSPacketWriter::xfrName
 static const string EncodeDNSLabel(const DNSName& input)
 {  
   if(!input.countLabels()) // otherwise we encode .. (long story)
@@ -483,11 +483,11 @@ void PacketReader::xfrHexBlob(string& blob, bool keepReading)
   xfrBlob(blob);
 }
 
-//FIXME remove this method completely
+//FIXME400 remove this method completely
 string simpleCompress(const string& elabel, const string& root)
 {
   string label=elabel;
-  // FIXME: this relies on the semi-canonical escaped output from getName
+  // FIXME400: this relies on the semi-canonical escaped output from getName
   if(strchr(label.c_str(), '\\')) {
     boost::replace_all(label, "\\.", ".");
     boost::replace_all(label, "\\032", " ");
@@ -512,7 +512,7 @@ string simpleCompress(const string& elabel, const string& root)
 }
 
 
-// FIXME this function needs to go
+// FIXME400 this function needs to go
 void simpleExpandTo(const string& label, unsigned int frompos, string& ret)
 {
   unsigned int labellen=0;

diff --git a/pdns/dnsparser.hh b/pdns/dnsparser.hh
index 70266c4816040e0ce3bfa1695f00f8f3121e6eea..f605b40552e2c60ef4c58c0d12992e6bae2e7a44 100644 (file)
--- a/pdns/dnsparser.hh
+++ b/pdns/dnsparser.hh
@@ -190,7 +190,7 @@ public:
 
   void doRecordCheck(const struct DNSRecord&){}
 
-  DNSName label; // FIXME rename
+  DNSName label; // FIXME400 rename
   struct dnsrecordheader header;
 
   typedef DNSRecordContent* makerfunc_t(const struct DNSRecord& dr, PacketReader& pr);  
@@ -263,7 +263,7 @@ protected:
 
 struct DNSRecord
 {
-  DNSName d_label; //FIXME rename
+  DNSName d_label; //FIXME400 rename
   std::shared_ptr<DNSRecordContent> d_content;
   uint16_t d_type;
   uint16_t d_class;
@@ -279,8 +279,8 @@ struct DNSRecord
     if(rhs.d_content)
       rzrp=toLower(rhs.d_content->getZoneRepresentation());
     
-    string llabel=toLower(d_label.toString()); //FIXME
-    string rlabel=toLower(rhs.d_label.toString()); //FIXME
+    string llabel=toLower(d_label.toString()); //FIXME400
+    string rlabel=toLower(rhs.d_label.toString()); //FIXME400
 
     return 
       tie(llabel,     d_type,     d_class, lzrp) <
@@ -295,8 +295,8 @@ struct DNSRecord
     if(rhs.d_content)
       rzrp=toLower(rhs.d_content->getZoneRepresentation());
     
-    string llabel=toLower(d_label.toString()); //FIXME
-    string rlabel=toLower(rhs.d_label.toString()); //FIXME
+    string llabel=toLower(d_label.toString()); //FIXME400
+    string rlabel=toLower(rhs.d_label.toString()); //FIXME400
     
     return 
       tie(llabel,     d_type,     d_class, lzrp) ==

diff --git a/pdns/dnsrecords.hh b/pdns/dnsrecords.hh
index 016fa8a39e7cf83d0ad6c9f0994b7d49c41b0415..685f28d2fe7b515f10c43cefc907541d52ee8f43 100644 (file)
--- a/pdns/dnsrecords.hh
+++ b/pdns/dnsrecords.hh
@@ -413,7 +413,7 @@ public:
   static void report(void);
   NSECRecordContent() : DNSRecordContent(47)
   {}
-  NSECRecordContent(const string& content, const string& zone=""); //DNSNameFIXME: DNSName& zone?
+  NSECRecordContent(const string& content, const string& zone=""); //FIXME400: DNSName& zone?
 
   static DNSRecordContent* make(const DNSRecord &dr, PacketReader& pr);
   static DNSRecordContent* make(const string& content);
@@ -430,7 +430,7 @@ public:
   static void report(void);
   NSEC3RecordContent() : DNSRecordContent(50)
   {}
-  NSEC3RecordContent(const string& content, const string& zone=""); //DNSNameFIXME: DNSName& zone?
+  NSEC3RecordContent(const string& content, const string& zone=""); //FIXME400: DNSName& zone?
 
   static DNSRecordContent* make(const DNSRecord &dr, PacketReader& pr);
   static DNSRecordContent* make(const string& content);
@@ -455,7 +455,7 @@ public:
   static void report(void);
   NSEC3PARAMRecordContent() : DNSRecordContent(51)
   {}
-  NSEC3PARAMRecordContent(const string& content, const string& zone=""); // DNSNameFIXME: DNSName& zone?
+  NSEC3PARAMRecordContent(const string& content, const string& zone=""); // FIXME400: DNSName& zone?
 
   static DNSRecordContent* make(const DNSRecord &dr, PacketReader& pr);
   static DNSRecordContent* make(const string& content);
@@ -496,7 +496,7 @@ public:
   static void report(void);
   WKSRecordContent() : DNSRecordContent(QType::WKS)
   {}
-  WKSRecordContent(const string& content, const string& zone=""); // FIXMEDNSName: DNSName& zone?
+  WKSRecordContent(const string& content, const string& zone=""); // FIXME400: DNSName& zone?
 
   static DNSRecordContent* make(const DNSRecord &dr, PacketReader& pr);
   static DNSRecordContent* make(const string& content);
@@ -514,7 +514,7 @@ public:
   EUI48RecordContent() : DNSRecordContent(QType::EUI48) {};
   static void report(void);
   static DNSRecordContent* make(const DNSRecord &dr, PacketReader& pr);
-  static DNSRecordContent* make(const string& zone); // FIXMEDNSName: DNSName& zone?
+  static DNSRecordContent* make(const string& zone); // FIXME400: DNSName& zone?
   void toPacket(DNSPacketWriter& pw);
   string getZoneRepresentation() const;
 private:
@@ -528,7 +528,7 @@ public:
   EUI64RecordContent() : DNSRecordContent(QType::EUI64) {};
   static void report(void);
   static DNSRecordContent* make(const DNSRecord &dr, PacketReader& pr);
-  static DNSRecordContent* make(const string& zone); // FIXMEDNSName: DNSName& zone?
+  static DNSRecordContent* make(const string& zone); // FIXME400: DNSName& zone?
   void toPacket(DNSPacketWriter& pw);
   string getZoneRepresentation() const;
 private:

diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index 728c41779936d8247b4496a763eb06a9049169d4..3a01ad05ebe2c1a02efaae01c68b7c5a54cab8a7 100644 (file)
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -294,7 +294,7 @@ string getMessageForRRSET(const DNSName& qname, const RRSIGRecordContent& rrc, v
   toHash.resize(toHash.size() - rrc.d_signature.length()); // chop off the end, don't sign the signature!
 
   BOOST_FOREACH(shared_ptr<DNSRecordContent>& add, signRecords) {
-    toHash.append(qname.toDNSString()); // FIXME tolower?
+    toHash.append(qname.toDNSString()); // FIXME400 tolower?
     uint16_t tmp=htons(rrc.d_type);
     toHash.append((char*)&tmp, 2);
     tmp=htons(1); // class
@@ -313,7 +313,7 @@ string getMessageForRRSET(const DNSName& qname, const RRSIGRecordContent& rrc, v
 DSRecordContent makeDSFromDNSKey(const DNSName& qname, const DNSKEYRecordContent& drc, int digest)
 {
   string toHash;
-  toHash.assign(qname.toDNSString()); // FIXME tolower?
+  toHash.assign(qname.toDNSString()); // FIXME400 tolower?
   toHash.append(const_cast<DNSKEYRecordContent&>(drc).serialize("", true, true));
   
   DSRecordContent dsrc;
@@ -570,7 +570,7 @@ string makeTSIGMessageFromTSIGPacket(const string& opacket, unsigned int tsigOff
     dw.xfrName(keyname, false);
     dw.xfr16BitInt(QClass::ANY); // class
     dw.xfr32BitInt(0);    // TTL
-    // dw.xfrName(toLower(trc.d_algoName), false); //FIXME 
+    // dw.xfrName(toLower(trc.d_algoName), false); //FIXME400 
     dw.xfrName(trc.d_algoName, false);
   }
   

diff --git a/pdns/dnswriter.cc b/pdns/dnswriter.cc
index 6ac0aa71dba42826bbb5cfa51552a4478a7614f3..53803f59989a611d7a4f417c5e6e30d21da28e9f 100644 (file)
--- a/pdns/dnswriter.cc
+++ b/pdns/dnswriter.cc
@@ -201,7 +201,7 @@ void DNSPacketWriter::xfrName(const DNSName& name, bool compress)
 {
   //cerr<<"xfrName: name=["<<name.toString()<<"] compress="<<compress<<endl;
   // string label = d_lowerCase ? toLower(Label) : Label;
-  // FIXME: we ignore d_lowerCase for now
+  // FIXME400: we ignore d_lowerCase for now
   // cerr<<"xfrName writing ["<<name.toString()<<"]"<<endl;
   std::vector<std::string> parts = name.getRawLabels();
   // labelparts_t parts;
@@ -256,7 +256,7 @@ void DNSPacketWriter::xfrName(const DNSName& name, bool compress)
     d_record.push_back(labelsize);
     unsigned int len=d_record.size();
     d_record.resize(len + labelsize);
-    memcpy(((&*d_record.begin()) + len), label.c_str(), labelsize); // FIXME do not want memcpy
+    memcpy(((&*d_record.begin()) + len), label.c_str(), labelsize); // FIXME400 do not want memcpy
     pos+=labelsize+1;
 
     if(pos - startPos == 1)

diff --git a/pdns/lua-auth.cc b/pdns/lua-auth.cc
index 7b206eed75e30397205b11ca801e2aa1892ad53e..89613de05adf007d52a9d2eb80269561536b58b1 100644 (file)
--- a/pdns/lua-auth.cc
+++ b/pdns/lua-auth.cc
@@ -67,7 +67,7 @@ bool AuthLua::axfrfilter(const ComboAddress& remote, const DNSName& zone, const
   }
   
   lua_pushstring(d_lua,  remote.toString().c_str() );
-  lua_pushstring(d_lua,  zone.toString().c_str() ); // FIXME expose DNSName to Lua?
+  lua_pushstring(d_lua,  zone.toString().c_str() ); // FIXME400 expose DNSName to Lua?
   lua_pushstring(d_lua,  in.qname.toString().c_str() );
   lua_pushnumber(d_lua,  in.qtype.getCode() );
   lua_pushnumber(d_lua,  in.ttl );

diff --git a/pdns/misc.cc b/pdns/misc.cc
index cd9cdecb92e424a7941bfe8c0c47e4e4414aeb5a..199639341bf85eaa5336123d9cee21d7825e7e1f 100644 (file)
--- a/pdns/misc.cc
+++ b/pdns/misc.cc
@@ -1011,7 +1011,7 @@ uint64_t udpErrorStats(const std::string& str)
 
 bool getTSIGHashEnum(const DNSName& algoName, TSIGHashEnum& algoEnum)
 {
-  if (algoName == "hmac-md5.sig-alg.reg.int." || algoName == "hmac-md5.") // FIXME
+  if (algoName == "hmac-md5.sig-alg.reg.int." || algoName == "hmac-md5.") // FIXME400
     algoEnum = TSIG_MD5;
   else if (algoName == "hmac-sha1.")
     algoEnum = TSIG_SHA1;

diff --git a/pdns/misc.hh b/pdns/misc.hh
index 03950241e26484963368f2f017240fafcd481675..eaeff786a070cb9ad9c9809f3d77f5d71e36d800 100644 (file)
--- a/pdns/misc.hh
+++ b/pdns/misc.hh
@@ -349,7 +349,7 @@ inline bool pdns_iequals(const std::string& a, const std::string& b)
   return true;
 }
 
-// FIXME remove this, it's just here to move faster while we DNSName the things
+// FIXME400 remove this, it's just here to move faster while we DNSName the things
 inline bool pdns_iequals(const DNSName& a, const DNSName& b) __attribute__((pure));
 inline bool pdns_iequals(const DNSName& a, const DNSName& b)
 {
@@ -438,7 +438,7 @@ private:
     #endif
 };
 
-// FIXME this should probably go?
+// FIXME400 this should probably go?
 struct CIStringCompare: public std::binary_function<string, string, bool>
 {
   bool operator()(const string& a, const string& b) const

diff --git a/pdns/nsec3dig.cc b/pdns/nsec3dig.cc
index 6860611e9f1c420b8d70a726068cdd92c8e929d8..44bf4e52518a15b3cf2f5a7884a97771cfab4618 100644 (file)
--- a/pdns/nsec3dig.cc
+++ b/pdns/nsec3dig.cc
@@ -135,7 +135,7 @@ try
       // cerr<<toBase32Hex(r.d_nexthash)<<endl;
       vector<string> parts;
       string sname=i->first.d_label.toString();
-      boost::split(parts, sname /* FIXME */, boost::is_any_of("."));
+      boost::split(parts, sname /* FIXME400 */, boost::is_any_of("."));
       nsec3s.insert(make_pair(toLower(parts[0]), toBase32Hex(r.d_nexthash)));
       nsec3salt = r.d_salt;
       nsec3iters = r.d_iterations;

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 4d47c520aaf813e9cc0c1fa371d8089e8689a14a..b56997654866de14170324035b855b0731295cd2 100644 (file)
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -452,7 +452,7 @@ void emitNSEC3(UeberBackend& B, const NSEC3PARAMRecordContent& ns3prc, const SOA
   r->addRecord(rr);
 }
 
-void PacketHandler::emitNSEC3(const NSEC3PARAMRecordContent& ns3prc, const SOAData& sd, const DNSName& unhashed, const string& begin, const string& end, /* FIXME unused */ const DNSName& toNSEC3, DNSPacket *r, int mode)
+void PacketHandler::emitNSEC3(const NSEC3PARAMRecordContent& ns3prc, const SOAData& sd, const DNSName& unhashed, const string& begin, const string& end, /* FIXME400 unused */ const DNSName& toNSEC3, DNSPacket *r, int mode)
 {
   ::emitNSEC3(B, ns3prc, sd, unhashed, begin, end, toNSEC3, r, mode);
   

diff --git a/pdns/packethandler.hh b/pdns/packethandler.hh
index a313fb3ef6cd123387245e22e29574b7c96601b4..de26e5e0d4c7932c5e9f79c6f7964df1974e8aee 100644 (file)
--- a/pdns/packethandler.hh
+++ b/pdns/packethandler.hh
@@ -78,7 +78,7 @@ private:
   void addNSEC(DNSPacket *p, DNSPacket* r, const DNSName &target, const DNSName &wildcard, const DNSName& auth, int mode);
   void addNSEC3(DNSPacket *p, DNSPacket* r, const DNSName &target, const DNSName &wildcard, const DNSName& auth, const NSEC3PARAMRecordContent& nsec3param, bool narrow, int mode);
   void emitNSEC(const DNSName& before, const DNSName& after, const DNSName& toNSEC, const SOAData& sd, DNSPacket *r, int mode);
-  void emitNSEC3(const NSEC3PARAMRecordContent &ns3rc, const SOAData& sd, const DNSName& unhashed, /* FIXME should this be DNSName? */ const string& begin, const string& end, const DNSName& toNSEC3, DNSPacket *r, int mode);
+  void emitNSEC3(const NSEC3PARAMRecordContent &ns3rc, const SOAData& sd, const DNSName& unhashed, /* FIXME400 should this be DNSName? */ const string& begin, const string& end, const DNSName& toNSEC3, DNSPacket *r, int mode);
   int processUpdate(DNSPacket *p);
   int forwardPacket(const string &msgPrefix, DNSPacket *p, DomainInfo *di);
   uint performUpdate(const string &msgPrefix, const DNSRecord *rr, DomainInfo *di, bool isPresigned, bool* narrow, bool* haveNSEC3, NSEC3PARAMRecordContent *ns3pr, bool *updatedSerial);

diff --git a/pdns/rfc2136handler.cc b/pdns/rfc2136handler.cc
index 535c9775b270e5fb2a01429bc7c12d180f3dc138..5fb06a916b156769ec9dd3c43c3e30c170ba08a2 100644 (file)
--- a/pdns/rfc2136handler.cc
+++ b/pdns/rfc2136handler.cc
@@ -119,7 +119,7 @@ uint PacketHandler::performUpdate(const string &msgPrefix, const DNSRecord *rr,
     if (rrType == QType::NSEC3PARAM) {
       L<<Logger::Notice<<msgPrefix<<"Adding/updating NSEC3PARAM for zone, resetting ordernames."<<endl;
 
-      NSEC3PARAMRecordContent nsec3param(rr->d_content->getZoneRepresentation(), di->zone.toString() /* FIXME huh */);
+      NSEC3PARAMRecordContent nsec3param(rr->d_content->getZoneRepresentation(), di->zone.toString() /* FIXME400 huh */);
       *narrow = false; // adding a NSEC3 will cause narrow mode to be dropped, as you cannot specify that in a NSEC3PARAM record
       d_dk.setNSEC3PARAM(di->zone, nsec3param, (*narrow));
 
@@ -160,7 +160,7 @@ uint PacketHandler::performUpdate(const string &msgPrefix, const DNSRecord *rr,
         } else {
           di->backend->updateDNSSECOrderNameAndAuth(di->id, di->zone, qname, DNSName(), (ddepth == 0));
         }
-        if (ddepth == 1 || dssets.count(qname)) // FIXME && ?
+        if (ddepth == 1 || dssets.count(qname)) // FIXME400 && ?
           di->backend->updateDNSSECOrderNameAndAuth(di->id, di->zone, qname, ordername, false, QType::DS);
       }
       return 1;
@@ -357,7 +357,7 @@ uint PacketHandler::performUpdate(const string &msgPrefix, const DNSRecord *rr,
               ordername=DNSName(toBase32Hex(hashQNameWithSalt(ns3pr->d_iterations, ns3pr->d_salt, *qname)))+di->zone;
 
             if (*narrow)
-              di->backend->updateDNSSECOrderNameAndAuth(di->id, di->zone, rr->d_label, DNSName(), auth); // FIXME no *qname here?
+              di->backend->updateDNSSECOrderNameAndAuth(di->id, di->zone, rr->d_label, DNSName(), auth); // FIXME400 no *qname here?
             else
               di->backend->updateDNSSECOrderNameAndAuth(di->id, di->zone, *qname, ordername, auth);
 
@@ -385,7 +385,7 @@ uint PacketHandler::performUpdate(const string &msgPrefix, const DNSRecord *rr,
       if (rr->d_class == QClass::ANY)
         d_dk.unsetNSEC3PARAM(rr->d_label);
       else if (rr->d_class == QClass::NONE) {
-        NSEC3PARAMRecordContent nsec3rr(rr->d_content->getZoneRepresentation(), di->zone.toString() /* FIXME huh */);
+        NSEC3PARAMRecordContent nsec3rr(rr->d_content->getZoneRepresentation(), di->zone.toString() /* FIXME400 huh */);
         if (ns3pr->getZoneRepresentation() == nsec3rr.getZoneRepresentation())
           d_dk.unsetNSEC3PARAM(rr->d_label);
         else

diff --git a/pdns/saxfr.cc b/pdns/saxfr.cc
index ff05a0141c4f2713e7b3bbfa9dbc857e096ce6f3..babf0cf60fe0cf21f899870e65f43ef3920f8c2c 100644 (file)
--- a/pdns/saxfr.cc
+++ b/pdns/saxfr.cc
@@ -314,7 +314,7 @@ try
   }
 
   for(auto &record: records) {
-    DNSName label /* FIXME rename */=record.first;
+    DNSName label /* FIXME400 rename */=record.first;
     if (isNSEC3 && unhash)
     {
       auto i = hashes.find(label.makeRelative(argv[3]).toStringNoDot());

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 5f4236d538980784ae3c41ff135acbdb91fc2925..0b0f994d7a1e2110aa7e76484d5bbd41392279b8 100644 (file)
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -787,7 +787,7 @@ bool SyncRes::doCacheCheck(const DNSName &qname, const QType &qtype, vector<DNSR
   return false;
 }
 
-// FIXME use DNSName.isPartOf
+// FIXME400 use DNSName.isPartOf
 bool SyncRes::moreSpecificThan(const DNSName& a, const DNSName &b)
 {
   return a.countLabels() > b.countLabels();

diff --git a/pdns/syncres.hh b/pdns/syncres.hh
index 930d2ec9be32cfd8015a622b943738b0e946b824..92b3d8e6bcf7a20559da0895a4aa10e3426769ba 100644 (file)
--- a/pdns/syncres.hh
+++ b/pdns/syncres.hh
@@ -464,7 +464,7 @@ private:
   struct GetBestNSAnswer
   {
     DNSName qname;
-    set<pair<DNSName,string> > bestns; // FIXME right side really should be DNSName too
+    set<pair<DNSName,string> > bestns; // FIXME400 right side really should be DNSName too
     uint8_t qtype; // only A and AAAA anyhow
     bool operator<(const GetBestNSAnswer &b) const
     {
@@ -531,7 +531,7 @@ struct PacketIDBirthdayCompare: public std::binary_function<PacketID, PacketID,
     if( tie(a.remote, ourSock, a.type) > tie(b.remote, bSock, b.type))
       return false;
 
-    return pdns_ilexicographical_compare(a.domain.toString(), b.domain.toString()); // FIXME
+    return pdns_ilexicographical_compare(a.domain.toString(), b.domain.toString()); // FIXME400
   }
 };
 extern __thread MemRecursorCache* t_RC;

diff --git a/pdns/tcpreceiver.cc b/pdns/tcpreceiver.cc
index 4e30bff3e4df468a3014979a0089b996441863bc..5d25068b0951a723c5573e3402fa37e3c2a26d14 100644 (file)
--- a/pdns/tcpreceiver.cc
+++ b/pdns/tcpreceiver.cc
@@ -627,7 +627,7 @@ int TCPNameserver::doAXFR(const DNSName &target, shared_ptr<DNSPacket> q, int ou
 
   if(!tsigkeyname.empty()) {
     string tsig64;
-    DNSName algorithm=trc.d_algoName; // FIXME: check
+    DNSName algorithm=trc.d_algoName; // FIXME400: check
     if (algorithm == "hmac-md5.sig-alg.reg.int")
       algorithm = "hmac-md5";
     if (algorithm != "gss-tsig") {
@@ -1057,7 +1057,7 @@ int TCPNameserver::doIXFR(shared_ptr<DNSPacket> q, int outsock)
 
     if(!tsigkeyname.empty()) {
       string tsig64;
-      DNSName algorithm=trc.d_algoName; // FIXME: was toLowerCanonic, compare output
+      DNSName algorithm=trc.d_algoName; // FIXME400: was toLowerCanonic, compare output
       if (algorithm == "hmac-md5.sig-alg.reg.int")
         algorithm = "hmac-md5";
       Lock l(&s_plock);

diff --git a/pdns/test-zoneparser_tng_cc.cc b/pdns/test-zoneparser_tng_cc.cc
index 5c9c591cbd9b704d932421ee8b0e386bb21472c9..c8ff12da8fe9cffcab97d10ca68e411af526ffc2 100644 (file)
--- a/pdns/test-zoneparser_tng_cc.cc
+++ b/pdns/test-zoneparser_tng_cc.cc
@@ -47,7 +47,7 @@ BOOST_AUTO_TEST_CASE(test_tng_record_types) {
     BOOST_CHECK_EQUAL(rr.ttl, ttl);
     BOOST_CHECK_EQUAL(rr.qtype.getName(), type);
     if (rr.qtype == QType::SOA)
-      continue; // FIXME remove trailing dots from data
+      continue; // FIXME400 remove trailing dots from data
     if (*(rr.content.rbegin()) != '.' && *(data.rbegin()) == '.') 
       BOOST_CHECK_EQUAL(rr.content, std::string(data.begin(),data.end()-1));
     else

diff --git a/pdns/ueberbackend.cc b/pdns/ueberbackend.cc
index 6cd4b8fd2078756325aad7bcaf4bba8a0da82307..a3e3f1de34d522788abc4b23efe81497a0888400 100644 (file)
--- a/pdns/ueberbackend.cc
+++ b/pdns/ueberbackend.cc
@@ -309,7 +309,7 @@ bool UeberBackend::getAuth(DNSPacket *p, SOAData *sd, const DNSName &target)
 
   for(vector<DNSBackend *>::const_iterator i=backends.begin(); i!=backends.end();++i)
     if((*i)->getAuth(p, sd, target, best_match_len)) {
-        best_match_len = sd->qname.countLabels(); // FIXME
+        best_match_len = sd->qname.countLabels(); // FIXME400
         from_cache = false;
 
         // Shortcut for the case that we got a direct hit - no need to go

diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index 0de69d4fa9354f50747950b91761ae67b64841a1..6a7e72cb401a7fe6c9620ac3f6c9bb8484fa2954 100644 (file)
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -674,7 +674,7 @@ static void apiServerZones(HttpRequest* req, HttpResponse* resp) {
       sd.nameserver = arg()["default-soa-name"];
       if (!arg().isEmpty("default-soa-mail")) {
         sd.hostmaster = arg()["default-soa-mail"];
-        // attodot(sd.hostmaster); FIXME
+        // attodot(sd.hostmaster); FIXME400
       } else {
         sd.hostmaster = "hostmaster." + zonename;
       }