]> granicus.if.org Git - python/commitdiff
changeset: 100749:0b61b2d28a07
authorVictor Stinner <victor.stinner@gmail.com>
Fri, 25 Mar 2016 14:12:08 +0000 (15:12 +0100)
committerVictor Stinner <victor.stinner@gmail.com>
Fri, 25 Mar 2016 14:12:08 +0000 (15:12 +0100)
tag: tip
parent: 100742:ebae81b31cf6
user: Victor Stinner <victor.stinner@gmail.com>
date: Fri Mar 25 15:03:34 2016 +0100
files: Lib/test/test_os.py
description:
test_os: Win32ErrorTests checks if file exists

Don't use os.path.exists() since it ignores *any* OSError.

Lib/test/test_os.py

index c8789d72a71775234982ab0c2dc66fd5e81ca762..f7d64b78389441c3d16498123fe55ed9f638fe2f 100644 (file)
@@ -1427,7 +1427,16 @@ class ExecTests(unittest.TestCase):
 @unittest.skipUnless(sys.platform == "win32", "Win32 specific tests")
 class Win32ErrorTests(unittest.TestCase):
     def setUp(self):
-        self.assertFalse(os.path.exists(support.TESTFN))
+        try:
+            os.stat(support.TESTFN)
+        except FileNotFoundError:
+            exists = False
+        except OSError as exc:
+            exists = True
+            self.fail("file %s must not exist; os.stat failed with %s"
+                      % (support.TESTFN, exc))
+        else:
+            self.fail("file %s must not exist" % support.TESTFN)
 
     def test_rename(self):
         self.assertRaises(OSError, os.rename, support.TESTFN, support.TESTFN+".bak")