bpo-26133: Fix typos (GH-5010) (#5014)

* Fix typos
* Change warning text
* Add test
(cherry picked from commit a8f4e15f3d33084862ddd3a7d58cd00034e94f16)

diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py
index 70b7050d9b77aefe9f3311b5eb383759faf7e437..b18824fd33b2839712c620384ad6071557e78822 100644 (file)
--- a/Lib/asyncio/unix_events.py
+++ b/Lib/asyncio/unix_events.py
@@ -66,9 +66,9 @@ class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop):
                 self.remove_signal_handler(sig)
         else:
             if self._signal_handlers:
-                warinigs.warn(f"Closing the loop {self!r} "
+                warnings.warn(f"Closing the loop {self!r} "
                               f"on interpreter shutdown "
-                              f"stage, signal unsubsription is disabled",
+                              f"stage, skipping signal handlers removal",
                               ResourceWarning,
                               source=self)
                 self._signal_handlers.clear()

diff --git a/Lib/test/test_asyncio/test_unix_events.py b/Lib/test/test_asyncio/test_unix_events.py
index 5a499841352bf92f96a38a9afee19283a7502443..868751bdedc76764ecc4ac6f5c0cf0856a450291 100644 (file)
--- a/Lib/test/test_asyncio/test_unix_events.py
+++ b/Lib/test/test_asyncio/test_unix_events.py
@@ -230,6 +230,23 @@ class SelectorEventLoopSignalTests(test_utils.TestCase):
         self.assertEqual(len(self.loop._signal_handlers), 0)
         m_signal.set_wakeup_fd.assert_called_once_with(-1)
 
+    @mock.patch('asyncio.unix_events.sys')
+    @mock.patch('asyncio.unix_events.signal')
+    def test_close_on_finalizing(self, m_signal, m_sys):
+        m_signal.NSIG = signal.NSIG
+        self.loop.add_signal_handler(signal.SIGHUP, lambda: True)
+
+        self.assertEqual(len(self.loop._signal_handlers), 1)
+        m_sys.is_finalizing.return_value = True
+        m_signal.signal.reset_mock()
+
+        with self.assertWarnsRegex(ResourceWarning,
+                                   "skipping signal handlers removal"):
+            self.loop.close()
+
+        self.assertEqual(len(self.loop._signal_handlers), 0)
+        self.assertFalse(m_signal.signal.called)
+
 
 @unittest.skipUnless(hasattr(socket, 'AF_UNIX'),
                      'UNIX Sockets are not supported')