PyType_Ready(): initialize the base class a bit earlier, so that if we

copy the metatype from the base, the base actually has one!

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 62f2822a84910ad25078966a49782106f53192e2..145923a2ca64b48e3cb5a6ec8f93fb5e9b40c7af 100644 (file)
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -2294,6 +2294,12 @@ PyType_Ready(PyTypeObject *type)
        if (base == NULL && type != &PyBaseObject_Type)
                base = type->tp_base = &PyBaseObject_Type;
 
+       /* Initialize the base class */
+       if (base && base->tp_dict == NULL) {
+               if (PyType_Ready(base) < 0)
+                       goto error;
+       }
+
        /* Initialize ob_type if NULL.  This means extensions that want to be
           compilable separately on Windows can call PyType_Ready() instead of
           initializing the ob_type field of their type objects. */
@@ -2312,12 +2318,6 @@ PyType_Ready(PyTypeObject *type)
                type->tp_bases = bases;
        }
 
-       /* Initialize the base class */
-       if (base && base->tp_dict == NULL) {
-               if (PyType_Ready(base) < 0)
-                       goto error;
-       }
-
        /* Initialize tp_dict */
        dict = type->tp_dict;
        if (dict == NULL) {