]> granicus.if.org Git - python/commitdiff
revert tstate_delete_common, since it's pretty much wrong
authorBenjamin Peterson <benjamin@python.org>
Tue, 17 Jun 2014 07:34:14 +0000 (00:34 -0700)
committerBenjamin Peterson <benjamin@python.org>
Tue, 17 Jun 2014 07:34:14 +0000 (00:34 -0700)
Python/pystate.c

index 7584ea0d832f4259d36438d25916f395e1cfeb9f..eb992c17801de094e7b0b1f294e5c59899cf9e44 100644 (file)
@@ -315,16 +315,9 @@ PyThreadState_DeleteCurrent()
         Py_FatalError(
             "PyThreadState_DeleteCurrent: no current tstate");
     _PyThreadState_Current = NULL;
-    /*
-      Only call tstate_delete_common to have the tstate if we're not finalizing
-      or we're the main thread. The main thread will do this for us. Not calling
-      tstate_delete_common means we won't lock the interpreter head lock,
-      avoiding a possible deadlock with the GIL.
-    */
-    if (!_Py_Finalizing || _Py_Finalizing == tstate)
-        tstate_delete_common(tstate);
     if (autoInterpreterState && PyThread_get_key_value(autoTLSkey) == tstate)
         PyThread_delete_key_value(autoTLSkey);
+    tstate_delete_common(tstate);
     PyEval_ReleaseLock();
 }
 #endif /* WITH_THREAD */