Expand shlex.quote example (#9723)

diff --git a/Doc/library/shlex.rst b/Doc/library/shlex.rst
index e5aec4a936f6890ca2062efaa0ba3b4d4098d510..908f996edfe75801827021da244abcb273a3216e 100644 (file)
--- a/Doc/library/shlex.rst
+++ b/Doc/library/shlex.rst
@@ -38,16 +38,33 @@ The :mod:`shlex` module defines the following functions:
 .. function:: quote(s)
 
    Return a shell-escaped version of the string *s*.  The returned value is a
-   string that can safely be used as one token in a shell command line.
-   Examples::
+   string that can safely be used as one token in a shell command line, for
+   cases where you cannot use a list.
+
+   This idiom would be unsafe::
+
+      >>> filename = 'somefile; rm -rf ~'
+      >>> command = 'ls -l {}'.format(filename)
+      >>> print(command)  # executed by a shell: boom!
+      ls -l somefile; rm -rf ~
+
+   :func:`quote` lets you plug the security hole::
 
-      >>> filename = 'somefile; rm -rf /home'
       >>> command = 'ls -l {}'.format(quote(filename))
       >>> print(command)
-      ls -l 'somefile; rm -rf /home'
+      ls -l 'somefile; rm -rf ~'
       >>> remote_command = 'ssh home {}'.format(quote(command))
       >>> print(remote_command)
-      ssh home 'ls -l '"'"'somefile; rm -rf /home'"'"''
+      ssh home 'ls -l '"'"'somefile; rm -rf ~'"'"''
+
+   The quoting is compatible with UNIX shells and with :func:`split`:
+
+      >>> remote_command = split(remote_command)
+      >>> remote_command
+      ['ssh', 'home', "ls -l 'somefile; rm -rf ~'"]
+      >>> command = split(remote_command[-1])
+      >>> command
+      ['ls', '-l', 'somefile; rm -rf ~']
 
 
 The :mod:`shlex` module defines the following class: