Fix ExprState's tag to be of type NodeTag rather than Node.

This appears to have been an oversight in b8d7f053c5c2. As it's
effectively harmless, though confusing, only fix in master.

Author: Andres Freund

diff --git a/src/backend/executor/execExpr.c b/src/backend/executor/execExpr.c
index 20ee1d3fb4bca33561a561dddd96c56df0c6537c..39442f8866ffcb55e9841b2f6cee512f215d81cf 100644 (file)
--- a/src/backend/executor/execExpr.c
+++ b/src/backend/executor/execExpr.c
@@ -361,7 +361,7 @@ ExecBuildProjectionInfo(List *targetList,
 
        projInfo->pi_exprContext = econtext;
        /* We embed ExprState into ProjectionInfo instead of doing extra palloc */
-       projInfo->pi_state.tag.type = T_ExprState;
+       projInfo->pi_state.tag = T_ExprState;
        state = &projInfo->pi_state;
        state->expr = (Expr *) targetList;
        state->parent = parent;

diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
index b593d22c48a6186927aab97663a38ace60c19e20..44f76082e99aec3255cda640772e571702a9f786 100644 (file)
--- a/src/include/nodes/execnodes.h
+++ b/src/include/nodes/execnodes.h
@@ -61,7 +61,7 @@ typedef Datum (*ExprStateEvalFunc) (struct ExprState *expression,
 
 typedef struct ExprState
 {
-       Node            tag;
+       NodeTag         tag;
 
        uint8           flags;                  /* bitmask of EEO_FLAG_* bits, see above */