]> granicus.if.org Git - python/commitdiff
Minor code style improvements in http.server suggested in Issue13294.
authorSenthil Kumaran <senthil@uthcode.com>
Fri, 23 Dec 2011 09:03:41 +0000 (17:03 +0800)
committerSenthil Kumaran <senthil@uthcode.com>
Fri, 23 Dec 2011 09:03:41 +0000 (17:03 +0800)
Lib/http/server.py

index 86fa37fd5a86905fe62472f98ffbbcfb8b4b9087..6642729af58b4534a55b775a51c6107da34d404a 100644 (file)
@@ -271,14 +271,11 @@ class BaseHTTPRequestHandler(socketserver.StreamRequestHandler):
         self.request_version = version = self.default_request_version
         self.close_connection = 1
         requestline = str(self.raw_requestline, 'iso-8859-1')
-        if requestline[-2:] == '\r\n':
-            requestline = requestline[:-2]
-        elif requestline[-1:] == '\n':
-            requestline = requestline[:-1]
+        requestline = requestline.rstrip('\r\n')
         self.requestline = requestline
         words = requestline.split()
         if len(words) == 3:
-            [command, path, version] = words
+            command, path, version = words
             if version[:5] != 'HTTP/':
                 self.send_error(400, "Bad request version (%r)" % version)
                 return False
@@ -304,7 +301,7 @@ class BaseHTTPRequestHandler(socketserver.StreamRequestHandler):
                           "Invalid HTTP Version (%s)" % base_version_number)
                 return False
         elif len(words) == 2:
-            [command, path] = words
+            command, path = words
             self.close_connection = 1
             if command != 'GET':
                 self.send_error(400,