]> granicus.if.org Git - llvm/commitdiff
[CMake] Update C4324 MSVC warning comment to explain its still broken at VS2019
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Tue, 20 Aug 2019 11:20:05 +0000 (11:20 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Tue, 20 Aug 2019 11:20:05 +0000 (11:20 +0000)
As promised, I've updated the comment for the C4324 MSVC warning that was re-disabled at rL367409 / rG8f823e63e3edf87ab029ba32b68f3eb5d2f392b5 to put it in terms of currently supported VS versions

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@369368 91177308-0d34-0410-b5e6-96231b3b80d8

cmake/modules/HandleLLVMOptions.cmake

index f6dafc10d7aa8059a11951ccadd6a6374484d3b0..e55bcab6e0315098977aec0eb06539b1f38acef1 100644 (file)
@@ -543,12 +543,10 @@ if (MSVC)
           # is fixed.
       -wd4709 # Suppress comma operator within array index expression
 
-      # Ideally, we'd like this warning to be enabled, but MSVC 2013 doesn't
+      # Ideally, we'd like this warning to be enabled, but even MSVC 2019 doesn't
       # support the 'aligned' attribute in the way that clang sources requires (for
       # any code that uses the LLVM_ALIGNAS macro), so this is must be disabled to
       # avoid unwanted alignment warnings.
-      # When we switch to requiring a version of MSVC that supports the 'alignas'
-      # specifier (MSVC 2015?) this warning can be re-enabled.
       -wd4324 # Suppress 'structure was padded due to __declspec(align())'
 
       # Promoted warnings.