]> granicus.if.org Git - python/commitdiff
bpo-30458: Disable https related urllib tests on a build without ssl (GH-13032)
authorXtreak <tir.karthi@gmail.com>
Wed, 1 May 2019 11:59:49 +0000 (17:29 +0530)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 1 May 2019 11:59:48 +0000 (04:59 -0700)
These tests require an SSL enabled build. Skip these tests when python is built without SSL to fix test failures.

https://bugs.python.org/issue30458

Lib/test/test_urllib.py

index e87c85b92876abb8242c11889fb3d87d70e81d85..c5b23f935b275bfdfc46295875c5ad6f80ecdca6 100644 (file)
@@ -329,6 +329,7 @@ class urlopen_HttpTests(unittest.TestCase, FakeHTTPMixin, FakeFTPMixin):
         finally:
             self.unfakehttp()
 
+    @unittest.skipUnless(ssl, "ssl module required")
     def test_url_with_control_char_rejected(self):
         for char_no in list(range(0, 0x21)) + [0x7f]:
             char = chr(char_no)
@@ -354,6 +355,7 @@ class urlopen_HttpTests(unittest.TestCase, FakeHTTPMixin, FakeFTPMixin):
             finally:
                 self.unfakehttp()
 
+    @unittest.skipUnless(ssl, "ssl module required")
     def test_url_with_newline_header_injection_rejected(self):
         self.fakehttp(b"HTTP/1.1 200 OK\r\n\r\nHello.")
         host = "localhost:7777?a=1 HTTP/1.1\r\nX-injected: header\r\nTEST: 123"