MFH: fix bug #37720 (merge_php_config scrambles values)

diff --git a/sapi/apache2handler/apache_config.c b/sapi/apache2handler/apache_config.c
index 729a4781254d20a887ad9c466301e86c31f4b3bc..9b01af7ffaa3cb6e925d99a87c0c3d2e9636ed99 100644 (file)
--- a/sapi/apache2handler/apache_config.c
+++ b/sapi/apache2handler/apache_config.c
@@ -118,27 +118,31 @@ static const char *php_apache_phpini_set(cmd_parms *cmd, void *mconfig, const ch
 
 void *merge_php_config(apr_pool_t *p, void *base_conf, void *new_conf)
 {
-       php_conf_rec *d = base_conf, *e = new_conf;
+       php_conf_rec *d = base_conf, *e = new_conf, *n = NULL;
        php_dir_entry *pe;
        php_dir_entry *data;
        char *str;
        uint str_len;
        ulong num_index;
 
-       phpapdebug((stderr, "Merge dir (%p) (%p)\n", base_conf, new_conf));
+       n = create_php_config(p, "merge_php_config");
+       zend_hash_copy(&n->config, &e->config, NULL, NULL, sizeof(php_dir_entry));
+
+       phpapdebug((stderr, "Merge dir (%p)+(%p)=(%p)\n", base_conf, new_conf, n));
        for (zend_hash_internal_pointer_reset(&d->config);
                        zend_hash_get_current_key_ex(&d->config, &str, &str_len, 
                                &num_index, 0, NULL) == HASH_KEY_IS_STRING;
                        zend_hash_move_forward(&d->config)) {
                pe = NULL;
                zend_hash_get_current_data(&d->config, (void **) &data);
-               if (zend_hash_find(&e->config, str, str_len, (void **) &pe) == SUCCESS) {
+               if (zend_hash_find(&n->config, str, str_len, (void **) &pe) == SUCCESS) {
                        if (pe->status >= data->status) continue;
                }
-               zend_hash_update(&e->config, str, str_len, data, sizeof(*data), NULL);
+               zend_hash_update(&n->config, str, str_len, data, sizeof(*data), NULL);
                phpapdebug((stderr, "ADDING/OVERWRITING %s (%d vs. %d)\n", str, data->status, pe?pe->status:-1));
        }
-       return new_conf;
+
+       return n;
 }
 
 char *get_php_config(void *conf, char *name, size_t name_len)