Bug #1653736: Complain about keyword arguments to time.isoformat.

diff --git a/Lib/test/test_datetime.py b/Lib/test/test_datetime.py
index 436cfcad7508bc055bcf0f69168554df000bacee..3aa0468837e60f287a5abfa9eb92b616d235f396 100644 (file)
--- a/Lib/test/test_datetime.py
+++ b/Lib/test/test_datetime.py
@@ -1740,6 +1740,11 @@ class TestTime(HarmlessMixedComparison):
         self.assertEqual(t.isoformat(), "00:00:00.100000")
         self.assertEqual(t.isoformat(), str(t))
 
+    def test_1653736(self):
+        # verify it doesn't accept extra keyword arguments
+        t = self.theclass(second=1)
+        self.assertRaises(TypeError, t.isoformat, foo=3)
+
     def test_strftime(self):
         t = self.theclass(1, 2, 3, 4)
         self.assertEqual(t.strftime('%H %M %S'), "01 02 03")

diff --git a/Misc/NEWS b/Misc/NEWS
index 8f15724b39fa1a925ea912a5839d44d201a23688..4d9eaee3174b3e9b48adc6dbc57dbdb1e3ffbfa1 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -105,6 +105,8 @@ Core and builtins
 Extension Modules
 -----------------
 
+- Bug #1653736: Complain about keyword arguments to time.isoformat.
+
 - operator.count() now raises an OverflowError when the count reaches sys.maxint.
 
 - Bug #1575169: operator.isSequenceType() now returns False for subclasses of dict.

diff --git a/Modules/datetimemodule.c b/Modules/datetimemodule.c
index 39a859f3e5d4a6b071ec97fccbf2f0deb793886a..cf8a68ba226e2e97f6d40d03022e93b1829a32ef 100644 (file)
--- a/Modules/datetimemodule.c
+++ b/Modules/datetimemodule.c
@@ -3167,7 +3167,7 @@ time_str(PyDateTime_Time *self)
 }
 
 static PyObject *
-time_isoformat(PyDateTime_Time *self)
+time_isoformat(PyDateTime_Time *self, PyObject *unused)
 {
        char buf[100];
        PyObject *result;
@@ -3411,7 +3411,7 @@ time_reduce(PyDateTime_Time *self, PyObject *arg)
 
 static PyMethodDef time_methods[] = {
 
-       {"isoformat",   (PyCFunction)time_isoformat,    METH_KEYWORDS,
+       {"isoformat",   (PyCFunction)time_isoformat,    METH_NOARGS,
         PyDoc_STR("Return string in ISO 8601 format, HH:MM:SS[.mmmmmm]"
                   "[+HH:MM].")},