]> granicus.if.org Git - clang/commitdiff
clang-format: Improve *-detection.
authorDaniel Jasper <djasper@google.com>
Tue, 19 May 2015 12:29:27 +0000 (12:29 +0000)
committerDaniel Jasper <djasper@google.com>
Tue, 19 May 2015 12:29:27 +0000 (12:29 +0000)
Before:
  S << a *(10);

After:
  S << a * (10);

This fixes llvm.org/PR16500.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@237690 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp

index a20790e8944fdac10746541c888a6d13d86fb6dc..7d38f8317e711c1746b82801592862dace2b34aa 100644 (file)
@@ -825,6 +825,9 @@ private:
             Previous->Type = TT_PointerOrReference;
         }
       }
+    } else if (Current.is(tok::lessless) &&
+               (!Current.Previous || !Current.Previous->is(tok::kw_operator))) {
+      Contexts.back().IsExpression = true;
     } else if (Current.isOneOf(tok::kw_return, tok::kw_throw)) {
       Contexts.back().IsExpression = true;
     } else if (Current.is(TT_TrailingReturnArrow)) {
index 5a568f4c0babf6ac5bd3ccc6dd045e678d0c9ab5..ead063fe41da685478359a659f4fe84d4d982c4e 100644 (file)
@@ -5468,6 +5468,8 @@ TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) {
   verifyIndependentOfContext("int a = *b;");
   verifyIndependentOfContext("int a = *b * c;");
   verifyIndependentOfContext("int a = b * *c;");
+  verifyIndependentOfContext("int a = b * (10);");
+  verifyIndependentOfContext("S << b * (10);");
   verifyIndependentOfContext("return 10 * b;");
   verifyIndependentOfContext("return *b * *c;");
   verifyIndependentOfContext("return a & ~b;");