Add missing va_end() call to a early exit in dmetaphone.c's StringAt().

Pointed out by Coverity.

Backpatch to all supported branches, the code has been that way for a
long while.

diff --git a/contrib/fuzzystrmatch/dmetaphone.c b/contrib/fuzzystrmatch/dmetaphone.c
index 5001288bb6424416c8c0b2fc5ea5d49b4aeeb22f..dcbc7782d4567661574ae319ea59a8c43b21ca52 100644 (file)
--- a/contrib/fuzzystrmatch/dmetaphone.c
+++ b/contrib/fuzzystrmatch/dmetaphone.c
@@ -359,7 +359,10 @@ StringAt(metastring *s, int start, int length,...)
        {
                test = va_arg(ap, char *);
                if (*test && (strncmp(pos, test, length) == 0))
+               {
+                       va_end(ap);
                        return 1;
+               }
        }
        while (strcmp(test, "") != 0);