fix typo in comparison in pathscross()

This was identified by GCC -Wlogical-op:

  dotsplines.c: In function ‘pathscross’:
  dotsplines.c:2498:32: warning: logical ‘and’ of equal expressions [-Wlogical-op]
       if ((ND_out(n0).size != 1) && (ND_out(n0).size != 1))
                                  ^~

Changes in this commit are the fix suggested by Stephen. Fixes #1926.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f71c2a843ed98ec717368f00d751d5f8511c12a5..60656b03f22d26c18eadfff36956640944686f09 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - broken overflow checks in RectArea #1906
 - various memory leaks !1699
 - Fix bad free in lefty !1709
+- typo in pathcross #1926
 
 ## [2.46.0] - 2021-01-18
 

diff --git a/lib/dotgen/dotsplines.c b/lib/dotgen/dotsplines.c
index c16864897a695f2a7271ec01d7ee69696de2f6cd..af27b9a7a64b98420d4850a1f2bd0e231d24acc6 100644 (file)
--- a/lib/dotgen/dotsplines.c
+++ b/lib/dotgen/dotsplines.c
@@ -2486,7 +2486,7 @@ static boolean pathscross(node_t *n0, node_t *n1, edge_t *ie1, edge_t *oe1)
     int order, cnt;
 
     order = (ND_order(n0) > ND_order(n1));
-    if ((ND_out(n0).size != 1) && (ND_out(n0).size != 1))
+    if ((ND_out(n0).size != 1) && (ND_out(n1).size != 1))
        return FALSE;
     e1 = oe1;
     if (ND_out(n0).size == 1 && e1) {