]> granicus.if.org Git - php/commitdiff
Don't explicitly set return value on ZPP failure
authorChristoph M. Becker <cmbecker69@gmx.de>
Fri, 16 Aug 2019 15:46:46 +0000 (17:46 +0200)
committerChristoph M. Becker <cmbecker69@gmx.de>
Fri, 16 Aug 2019 15:54:11 +0000 (17:54 +0200)
Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.

ext/bz2/bz2.c

index bf706f644935d564c94804e8f337396798d4f646..b4079df5d5d685ff93688fba5296b90fb8762d6f 100644 (file)
@@ -335,7 +335,7 @@ static PHP_FUNCTION(bzread)
        zend_string *data;
 
        if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "r|l", &bz, &len)) {
-               RETURN_FALSE;
+               return;
        }
 
        php_stream_from_zval(stream, bz);
@@ -535,7 +535,7 @@ static PHP_FUNCTION(bzdecompress)
        bz_stream bzs;
 
        if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "s|l", &source, &source_len, &small)) {
-               RETURN_FALSE;
+               return;
        }
 
        bzs.bzalloc = NULL;