]> granicus.if.org Git - llvm/commitdiff
Revert r316064 "Fix the incorrect detection of ICONV_LIBRARY_PATH"
authorHans Wennborg <hans@hanshq.net>
Mon, 6 Nov 2017 22:17:23 +0000 (22:17 +0000)
committerHans Wennborg <hans@hanshq.net>
Mon, 6 Nov 2017 22:17:23 +0000 (22:17 +0000)
This broke the use of libxml2 on machines where iconv() is provided by libc.
I'll follow up on the mailing list to discuss how to fix this properly.

> This is introduced in rL308711.
> Check for c library is incorrect here just because libc will be found always
> and it does not mean that iconv is presented.
>
> Thank to Andrew Krasny for narrowing down the root cause.
>
> Reviewers: ecbeckmann
> Reviewed By: ecbeckmann
> Subscribers: mgorny, llvm-commits
> Differential Revision: https://reviews.llvm.org/D38875

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@317517 91177308-0d34-0410-b5e6-96231b3b80d8

cmake/config-ix.cmake

index a1b4846f19ab13efa03363d7c3c5cbabff123476..7f33591de0c89fdff0fbaeb10f831e8caaee55ce 100644 (file)
@@ -157,7 +157,7 @@ if( NOT PURE_WINDOWS AND NOT LLVM_USE_SANITIZER MATCHES "Memory.*")
     set(HAVE_TERMINFO 0)
   endif()
 
-  find_library(ICONV_LIBRARY_PATH NAMES iconv libiconv libiconv-2)
+  find_library(ICONV_LIBRARY_PATH NAMES iconv libiconv libiconv-2 c)
   set(LLVM_LIBXML2_ENABLED 0)
   set(LIBXML2_FOUND 0)
   if((LLVM_ENABLE_LIBXML2) AND ((CMAKE_SYSTEM_NAME MATCHES "Linux") AND (ICONV_LIBRARY_PATH) OR APPLE))