Merge r1711479, r1733064, r1733068 from trunk:

Fix crash in ap_mpm_pod_check call caused by NULL dereference of its parameter
when starting httpd as single process (httpd -X).

Revert changes on mpm_event and mpm_worker from r1711479.
The POD is not used in one process mode for those MPMs.

Follow up to r1711479 and r1733064: CHANGES entry.
Submitted by: jkaluza, ylavic, ylavic
Reviewed/backported by: jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1733475 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index 04c16cd6c7d6eba09df6681aba04443e7b35af78..bd2470214db849288d47499a4718f5c635432b8a 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -75,6 +75,9 @@ Changes with Apache 2.4.19
   *) mod_http2: bytes read/written on slave connections are reported via the
      optional mod_logio functions. Fixes PR 58871.
 
+  *) prefork: Initialize the POD when running in ONE_PROCESS (or -X) mode to
+     avoid a crash.  [Jan Kaluza, Yann Ylavic]
+
   *) mod_ssl: Add SSLOCSPProxyURL to add the possibility to do all queries
      to OCSP responders through a HTTP proxy. [Ruediger Pluem]
 

diff --git a/STATUS b/STATUS
index cd2f18907b1c9073fca1d7bbf69e862aee542e54..970a949c31c23ba1a473dc3c3f836c2204d3a690 100644 (file)
--- a/STATUS
+++ b/STATUS
@@ -112,14 +112,6 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
-   * prefork: Fix crash in ap_mpm_pod_check call caused by NULL dereference of
-           its parameter when starting httpd as single process (httpd -X).
-     trunk patch: http://svn.apache.org/r1711479
-                  http://svn.apache.org/r1733064
-                  http://svn.apache.org/r1733068
-     2.4.x patch: http://home.apache.org/~ylavic/patches/httpd-2.4.x-prefork-ONE_PROCESS_POD.patch
-     +1: ylavic, icing, jim
-
   *) mod_ssl: When SSLVerify is disabled (NONE), don't force a renegotiation if
      the SSLVerifyDepth applied with the default/handshaken vhost differs from
      the one applicable with the finally selected vhost.

diff --git a/server/mpm/prefork/prefork.c b/server/mpm/prefork/prefork.c
index 19adec45a88a307f96bb59a9f5a5d83489bb1585..f2b4e410cc9d8bbc86ffb5b9f98b7a29493e7623 100644 (file)
--- a/server/mpm/prefork/prefork.c
+++ b/server/mpm/prefork/prefork.c
@@ -1316,8 +1316,7 @@ static int prefork_open_logs(apr_pool_t *p, apr_pool_t *plog, apr_pool_t *ptemp,
     all_buckets = apr_pcalloc(pconf, num_buckets *
                                      sizeof(prefork_child_bucket));
     for (i = 0; i < num_buckets; i++) {
-        if (!one_process && /* no POD in one_process mode */
-                (rv = ap_mpm_pod_open(pconf, &all_buckets[i].pod))) {
+        if ((rv = ap_mpm_pod_open(pconf, &all_buckets[i].pod))) {
             ap_log_error(APLOG_MARK, APLOG_CRIT | level_flags, rv,
                          (startup ? NULL : s),
                          "could not open pipe-of-death");