Fix deadlock at startup, if max_prepared_transactions is too small.

When the startup process recovers transactions by scanning pg_twophase
directory, it should clear MyLockedGxact after it's done processing each
transaction. Like we do during normal operation, at PREPARE TRANSACTION.
Otherwise, if the startup process exits due to an error, it will try to
clear the locking_backend field of the last recovered transaction. That's
usually harmless, but if the error happens in MarkAsPreparing, while
holding TwoPhaseStateLock, the shmem-exit hook will try to acquire
TwoPhaseStateLock again, and deadlock with itself.

This fixes bug #13128 reported by Grant McAlister. The bug was introduced
by commit bb38fb0d, so backpatch to all supported versions like that
commit.

diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index b85a666ca1cc19ba6c71294399d632d161203ae8..3ac339bebfceb4976684a69cba63dd9b1c7ad7c0 100644 (file)
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -2054,6 +2054,12 @@ RecoverPreparedTransactions(void)
                        if (InHotStandby)
                                StandbyReleaseLockTree(xid, hdr->nsubxacts, subxids);
 
+                       /*
+                        * We're done with recovering this transaction. Clear MyLockedGxact,
+                        * like we do in PrepareTransaction() during normal operation.
+                        */
+                       PostPrepare_Twophase();
+
                        pfree(buf);
                }
        }