]> granicus.if.org Git - libevent/commitdiff
bev_async: do not initialize timeouts multiple times
authorAzat Khuzhin <a3at.mail@gmail.com>
Tue, 13 Nov 2018 08:47:14 +0000 (11:47 +0300)
committerAzat Khuzhin <a3at.mail@gmail.com>
Tue, 13 Nov 2018 19:29:08 +0000 (22:29 +0300)
You cannot event_assign() event multiple times, this is UB, and most
likely will fail.

Fixes: af9b2a7ae0be11c79a909d212b1833a9379e4ba0 ("Initialize async
bufferevent timeout CBs unconditionally")

bufferevent_async.c

index 1cd9e5c37af85519f5783d209859650d1d0da6d4..63ff7c375b7328d235d331c7b243eaa0fb8ce178 100644 (file)
@@ -589,7 +589,6 @@ bufferevent_async_set_connected_(struct bufferevent *bev)
 {
        struct bufferevent_async *bev_async = upcast(bev);
        bev_async->ok = 1;
-       bufferevent_init_generic_timeout_cbs_(bev);
        /* Now's a good time to consider reading/writing */
        be_async_enable(bev, bev->enabled);
 }