add 'a' to chmod in llvm-lipo executability tests

Summary:
When specifying symbolic permissions with + or -, if none of
a/u/g/o are specified, bits set in the umask are not affected.
This caused the llvm-lipo executability tests to fail on some
systems, e.g. having an umask of 027 would cause chmod -x to not
clear the executable bit for others. This change instead
uses chmod a-x, which clears all the executable bits regardless
of umask.

Reviewers: smeenai, hans, anushabasana

Reviewed By: smeenai

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65342

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@367142 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/test/tools/llvm-lipo/create-executable.test b/test/tools/llvm-lipo/create-executable.test
index 19b3bfef3d4c1ade50d5ad67eeb3603a5c136b96..43e29a71e846dd992d8bba077157e4db55c7d75d 100644 (file)
--- a/test/tools/llvm-lipo/create-executable.test
+++ b/test/tools/llvm-lipo/create-executable.test
@@ -3,11 +3,11 @@
 # RUN: yaml2obj %p/Inputs/i386-slice.yaml > %t-i386.o
 # RUN: yaml2obj %p/Inputs/x86_64-slice.yaml > %t-x86_64.o
 
-# RUN: chmod -x %t-i386.o
-# RUN: chmod -x %t-x86_64.o
+# RUN: chmod a-x %t-i386.o
+# RUN: chmod a-x %t-x86_64.o
 # RUN: llvm-lipo %t-i386.o %t-x86_64.o -create -output %t-universal.o
 # RUN: test ! -x %t-universal.o
 
-# RUN: chmod +x %t-i386.o
+# RUN: chmod a+x %t-i386.o
 # RUN: llvm-lipo %t-i386.o %t-x86_64.o -create -output %t-universal.o
 # RUN: test -x %t-universal.o

diff --git a/test/tools/llvm-lipo/thin-executable-universal-binary.test b/test/tools/llvm-lipo/thin-executable-universal-binary.test
index 3992373d9e46f516acbd7abe03c47cbea69e071d..20dd1dbc2beff2d196c6ce595daa1fe0a71ce572 100644 (file)
--- a/test/tools/llvm-lipo/thin-executable-universal-binary.test
+++ b/test/tools/llvm-lipo/thin-executable-universal-binary.test
@@ -2,11 +2,11 @@
 # UNSUPPORTED: system-windows
 # RUN: yaml2obj %s > %t-universal.o
 
-# RUN: chmod -x %t-universal.o
+# RUN: chmod a-x %t-universal.o
 # RUN: llvm-lipo %t-universal.o -thin i386 -output %t32.o
 # RUN: test ! -x %t32.o
 
-# RUN: chmod +x %t-universal.o
+# RUN: chmod a+x %t-universal.o
 # RUN: llvm-lipo %t-universal.o -thin i386 -output %t32-ex.o
 # RUN: test -x %t32-ex.o