* libmisc/chkname.c: Use a bool when possible instead of integers.

	* libmisc/chkname.c: Add brackets and parenthesis.

diff --git a/ChangeLog b/ChangeLog
index 73c4325406d0755ebe949ed6b632fbe8347f3f89..31dfd3ce0a506f1597a823cfd1bbf53d0bf704b1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-12-23  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * libmisc/chkname.c: Use a bool when possible instead of integers.
+       * libmisc/chkname.c: Add brackets and parenthesis.
+
 2008-12-23  Nicolas François  <nicolas.francois@centraliens.net>
 
        * man/groupadd.8.xml, configure.in, man/config.xml.in: Use the

diff --git a/libmisc/chkname.c b/libmisc/chkname.c
index 5e400966dd028b23b0ee472671d955bf6ebedc9c..67c4e3eb06b992c4832ae52c358ea044498cf7c6 100644 (file)
--- a/libmisc/chkname.c
+++ b/libmisc/chkname.c
@@ -100,8 +100,10 @@ bool is_valid_group_name (const char *name)
         * Arbitrary limit for group names.
         * HP-UX 10 limits to 16 characters
         */
-       if (GROUP_NAME_MAX_LENGTH && strlen (name) > GROUP_NAME_MAX_LENGTH)
+       if (   (GROUP_NAME_MAX_LENGTH > 0)
+           && (strlen (name) > GROUP_NAME_MAX_LENGTH)) {
                return false;
+       }
 
        return is_valid_name (name);
 }