Print optional message for attr(unavailable) in C++ mode.

// rdar://9046492

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126499 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td
index 487b3c4d6a5b4bd0cd328cecc22aed0c3e29916d..3c00e8b5c3b8e70d2416fcdaacdc25a43f95c643 100644 (file)
--- a/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/include/clang/Basic/DiagnosticSemaKinds.td
@@ -1312,6 +1312,8 @@ def err_ovl_ambiguous_call : Error<
   "call to %0 is ambiguous">;
 def err_ovl_deleted_call : Error<
   "call to %select{unavailable|deleted}0 function %1">;
+def err_ovl_unavailable_call : Error<
+  "call to unavailable function %0: %1">;
 def err_ovl_ambiguous_member_call : Error<
   "call to member function %0 is ambiguous">;
 def err_ovl_deleted_member_call : Error<

diff --git a/lib/Sema/SemaOverload.cpp b/lib/Sema/SemaOverload.cpp
index c59bfec81161d3114f1ef91a1192b77ec08a8634..1da95b6a358302bd29baea4893bbcebdffc4b301 100644 (file)
--- a/lib/Sema/SemaOverload.cpp
+++ b/lib/Sema/SemaOverload.cpp
@@ -7709,11 +7709,24 @@ Sema::BuildOverloadedCallExpr(Scope *S, Expr *Fn, UnresolvedLookupExpr *ULE,
     break;
 
   case OR_Deleted:
-    Diag(Fn->getSourceRange().getBegin(), diag::err_ovl_deleted_call)
-      << Best->Function->isDeleted()
-      << ULE->getName()
-      << Fn->getSourceRange();
-    CandidateSet.NoteCandidates(*this, OCD_AllCandidates, Args, NumArgs);
+    {
+      llvm::StringRef Message;
+      if (const UnavailableAttr *UA = 
+            Best->Function->getAttr<UnavailableAttr>()) 
+        Message = UA->getMessage();
+
+      if (Message.empty())
+        Diag(Fn->getSourceRange().getBegin(), diag::err_ovl_deleted_call)
+          << Best->Function->isDeleted()
+          << ULE->getName()
+          << Fn->getSourceRange();
+      else
+        Diag(Fn->getSourceRange().getBegin(), diag::err_ovl_unavailable_call)
+          << ULE->getName()
+          << Message
+          << Fn->getSourceRange();
+      CandidateSet.NoteCandidates(*this, OCD_AllCandidates, Args, NumArgs);
+    }
     break;
   }
 

diff --git a/test/SemaCXX/attr-unavailable.cpp b/test/SemaCXX/attr-unavailable.cpp
index 6f5aa5e78c4c639d479803d0077c996950baf098..81db505e1e221af06f9e762765cf345e5f142250 100644 (file)
--- a/test/SemaCXX/attr-unavailable.cpp
+++ b/test/SemaCXX/attr-unavailable.cpp
@@ -18,3 +18,14 @@ void test_foo(short* sp) {
   int &(*fp3)(int) = foo;
   void (*fp4)(...) = foo; // expected-error{{'foo' is unavailable}}
 }
+
+namespace radar9046492 {
+// rdar://9046492
+#define FOO __attribute__((unavailable("not available - replaced")))
+
+void foo() FOO; // expected-note {{candidate function has been explicitly made unavailable}}
+
+void bar() {
+  foo(); // expected-error {{call to unavailable function 'foo': not available - replaced}}
+}
+}