Don't warn on missing 'copy' attribute on a 'block'

property when it is 'readonly'. // rdar://8820813

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@122923 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaObjCProperty.cpp b/lib/Sema/SemaObjCProperty.cpp
index 6aa1c693bc98b22259c9b095f16e059ab15f4940..71d87923456b1927de5a73509fd2d9223d12dd04 100644 (file)
--- a/lib/Sema/SemaObjCProperty.cpp
+++ b/lib/Sema/SemaObjCProperty.cpp
@@ -1326,6 +1326,7 @@ void Sema::CheckObjCPropertyAttributes(Decl *PDecl,
   }
 
   if (!(Attributes & ObjCDeclSpec::DQ_PR_copy)
+      &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly)
       && getLangOptions().getGCMode() == LangOptions::GCOnly
       && PropertyTy->isBlockPointerType())
     Diag(Loc, diag::warn_objc_property_copy_missing_on_block);

diff --git a/test/SemaObjC/block-attr.m b/test/SemaObjC/block-attr.m
index de203e711ede73b4a577b8da2a63b4cdbab254c3..80092fc31c1adbc00612e4e7b7677190e00d376e 100644 (file)
--- a/test/SemaObjC/block-attr.m
+++ b/test/SemaObjC/block-attr.m
@@ -6,5 +6,7 @@
 @property void(^someBlock)(void); // expected-warning {{'copy' attribute must be specified for the block property}}
 @property(copy)  void(^OK)(void);
 
+// rdar://8820813
+@property (readonly) void (^block)(void); // readonly property is OK
 
 @end