Fix leak in previous commit
authorNikita Popov <nikic@php.net>
Fri, 14 Aug 2015 15:04:33 +0000 (17:04 +0200)
committerNikita Popov <nikic@php.net>
Fri, 14 Aug 2015 15:04:33 +0000 (17:04 +0200)
Turns out zend_update_property_str already does the copy implicitly.

Zend/zend_exceptions.c

index 53a4ac2026845b98f1376724441087463197164a..d7df5df0bfdaab895fe9f90c60a4010a642f16d8 100644 (file)
@@ -207,11 +207,10 @@ static zend_object *zend_default_exception_new_ex(zend_class_entry *class_type,
        base_ce = i_get_exception_base(&obj);
 
        if (EXPECTED(class_type != zend_ce_parse_error || !(filename = zend_get_compiled_filename()))) {
-               zend_update_property_str(base_ce, &obj, "file", sizeof("file")-1,
-                       zend_string_copy(zend_get_executed_filename_ex()));
+               zend_update_property_str(base_ce, &obj, "file", sizeof("file")-1, zend_get_executed_filename_ex());
                zend_update_property_long(base_ce, &obj, "line", sizeof("line")-1, zend_get_executed_lineno());
        } else {
-               zend_update_property_str(base_ce, &obj, "file", sizeof("file")-1, zend_string_copy(filename));
+               zend_update_property_str(base_ce, &obj, "file", sizeof("file")-1, filename);
                zend_update_property_long(base_ce, &obj, "line", sizeof("line")-1, zend_get_compiled_lineno());
        }
        zend_update_property(base_ce, &obj, "trace", sizeof("trace")-1, &trace);