]> granicus.if.org Git - clang/commitdiff
Add another two ExtVectorComponent FIXMEs.
authorDaniel Dunbar <daniel@zuster.org>
Sun, 18 Oct 2009 02:09:38 +0000 (02:09 +0000)
committerDaniel Dunbar <daniel@zuster.org>
Sun, 18 Oct 2009 02:09:38 +0000 (02:09 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@84393 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaExpr.cpp

index b32c6840192643f9d81a421f93b3f11cf8818e77..b98b67fd741bc40c84b86925a0924f40b1c441e4 100644 (file)
@@ -1877,6 +1877,11 @@ QualType Sema::
 CheckExtVectorComponent(QualType baseType, SourceLocation OpLoc,
                         const IdentifierInfo *CompName,
                         SourceLocation CompLoc) {
+  // FIXME: Share logic with ExtVectorElementExpr::containsDuplicateElements,
+  // see FIXME there.
+  //
+  // FIXME: This logic can be greatly simplified by splitting it along
+  // halving/not halving and reworking the component checking.
   const ExtVectorType *vecType = baseType->getAs<ExtVectorType>();
 
   // The vector accessor can't exceed the number of elements.