]> granicus.if.org Git - clang/commitdiff
Fix PR clang/3175: CheckAddressOfOperand does not handle references to class vars
authorDouglas Gregor <dgregor@apple.com>
Wed, 10 Dec 2008 21:26:49 +0000 (21:26 +0000)
committerDouglas Gregor <dgregor@apple.com>
Wed, 10 Dec 2008 21:26:49 +0000 (21:26 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@60849 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaExpr.cpp
test/SemaCXX/address-of.cpp [new file with mode: 0644]

index a36bcf588065bedd45eb8ead6a11f39627f2b43b..8cbbca3fbf0b9d5183920eb00bbe78a694b95c57 100644 (file)
@@ -2876,8 +2876,11 @@ QualType Sema::CheckAddressOfOperand(Expr *op, SourceLocation OpLoc) {
           << "register variable" << op->getSourceRange();
         return QualType();
       }
-    } else if (isa<OverloadedFunctionDecl>(dcl))
+    } else if (isa<OverloadedFunctionDecl>(dcl)) {
       return Context.OverloadTy;
+    } else if (isa<FieldDecl>(dcl)) {
+      // Okay: we can take the address of a field.
+    }
     else 
       assert(0 && "Unknown/unexpected decl type");
   }
diff --git a/test/SemaCXX/address-of.cpp b/test/SemaCXX/address-of.cpp
new file mode 100644 (file)
index 0000000..5451f32
--- /dev/null
@@ -0,0 +1,31 @@
+// RUN: clang -fsyntax-only -verify %S
+// PR clang/3175
+
+void bar(int*);
+
+class c {
+  int var;
+  static int svar;
+  void foo() { 
+    bar(&var); 
+    bar(&svar);  
+  }
+
+  static void wibble() {
+    bar(&var); // expected-error{{invalid use of member 'var' in static member function}}
+    bar(&svar); 
+  }
+};
+
+enum E {
+  Enumerator
+};
+
+void test() {
+  (void)&Enumerator; // expected-error{{address expression must be an lvalue or a function designator}}
+}
+
+template<int N>
+void test2() {
+  (void)&N; // expected-error{{address expression must be an lvalue or a function designator}}
+}