Eric Vergnaud found a use of an uninitialized variable

diff --git a/CHANGES b/CHANGES
index 901f077bbafc3d188e2868bc807be8dfb0cb6580..764b3467f4a1b4d3bee1ad04f2dd9039cdb34631 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,13 @@
 
                                   Changelog
 
+Daniel (5 February 2005)
+- Eric Vergnaud found a use of an uninitialised variable in the ftp when doing
+  PORT on ipv6-enabled hosts.
+
+- David Byron pointed out we could use BUFSIZE to read data (in
+  lib/transfer.c) instead of using BUFSIZE -1.
+
 Version 7.13.0 (1 February 2005)
 
 Daniel (31 January 2005)

diff --git a/lib/ftp.c b/lib/ftp.c
index e6d2cdfae15053a2dba1e5fec80e6c153a10af39..ddbd4968f9a17e59e766889a4d97d39cd4a1b94f 100644 (file)
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -1127,7 +1127,7 @@ CURLcode ftp_use_port(struct connectdata *conn)
    *
    */
 
-  struct addrinfo hints, *res, *ai;
+  struct addrinfo *res, *ai;
   struct sockaddr_storage ss;
   socklen_t sslen;
   char hbuf[NI_MAXHOST]="";
@@ -1190,7 +1190,7 @@ CURLcode ftp_use_port(struct connectdata *conn)
      * Workaround for AIX5 getaddrinfo() problem (it doesn't set ai_socktype):
      */
     if (ai->ai_socktype == 0)
-      ai->ai_socktype = hints.ai_socktype;
+      ai->ai_socktype = SOCK_STREAM;
 
     portsock = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
     if (portsock == CURL_SOCKET_BAD) {