* src/su.c: Do not sanitize the environment. This breaks

	--preserve-environment. This sanitation was disabled on Debian
	since quite some time with no reported issues, and sanitize_env()
	documentation agrees that it should be useless as all modern
	Unixes will handle setuid executables properly. This Fixes
	Alioth#312287.

diff --git a/ChangeLog b/ChangeLog
index f3944417691724608a49da5ae81b4b3eec464b0d..e440b310b543129645571fc4d2b296441769ca70 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2009-01-24  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * src/su.c: Do not sanitize the environment. This breaks
+       --preserve-environment. This sanitation was disabled on Debian
+       since quite some time with no reported issues, and sanitize_env()
+       documentation agrees that it should be useless as all modern
+       Unixes will handle setuid executables properly. This Fixes
+       Alioth#312287.
+
 2009-01-24  Nicolas François  <nicolas.francois@centraliens.net>
 
        * libmisc/setupenv.c: Fix typo from 2009-11-01.

diff --git a/src/su.c b/src/su.c
index 97970037ec67563e32371e6dd47212a0755aecd7..a0ee6d8d6538c2923bce7232e7a2abc42f1d99b1 100644 (file)
--- a/src/su.c
+++ b/src/su.c
@@ -409,8 +409,6 @@ int main (int argc, char **argv)
 #endif
 #endif                         /* !USE_PAM */
 
-       sanitize_env ();
-
        (void) setlocale (LC_ALL, "");
        (void) bindtextdomain (PACKAGE, LOCALEDIR);
        (void) textdomain (PACKAGE);