]> granicus.if.org Git - sudo/commitdiff
Fix NULL deref if base64_decode returns -1.
authorTodd C. Miller <Todd.Miller@courtesan.com>
Tue, 22 Jul 2014 20:53:15 +0000 (14:53 -0600)
committerTodd C. Miller <Todd.Miller@courtesan.com>
Tue, 22 Jul 2014 20:53:15 +0000 (14:53 -0600)
plugins/sudoers/ldap.c

index cd8398ef48b9b8952d331b0be69c67c5570c27d5..1c09906529150a4f732f6abd55a2dd5b2baea56a 100644 (file)
@@ -1403,8 +1403,9 @@ sudo_ldap_decode_secret(const char *secret)
        if (len == (size_t)-1) {
            free(result);
            result = NULL;
+       } else {
+           result[len] = '\0';
        }
-       result[len] = '\0';
     }
     debug_return_str((char *)result);
 }