MFH: Ilia's patch for bug #21268 (session_decode() returned FALSE on success)

diff --git a/ext/session/session.c b/ext/session/session.c
index 8b6be415abfc3d224e0de2f7bc18a35aaece96ba..2af454d622ec7cf28a4f37eeec3f191f6b6e78ec 100644 (file)
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -1433,15 +1433,19 @@ PHP_FUNCTION(session_decode)
 {
        zval **str;
 
-       if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &str) == FAILURE)
+       if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &str) == FAILURE) {
                WRONG_PARAM_COUNT;
+       }
 
-       if (PS(session_status) == php_session_none)
+       if (PS(session_status) == php_session_none) {
                RETURN_FALSE;
+       }
 
        convert_to_string_ex(str);
 
        php_session_decode(Z_STRVAL_PP(str), Z_STRLEN_PP(str) TSRMLS_CC);
+
+       RETURN_TRUE;
 }
 /* }}} */