]> granicus.if.org Git - python/commitdiff
simplify and reformat
authorBenjamin Peterson <benjamin@python.org>
Mon, 23 Apr 2012 22:00:25 +0000 (18:00 -0400)
committerBenjamin Peterson <benjamin@python.org>
Mon, 23 Apr 2012 22:00:25 +0000 (18:00 -0400)
Objects/unicodeobject.c

index 2b90cfad726a0d081eda0beb02cb0d8cd14c5636..95ecfe2ae090f49990149ba057135d1df442bbf6 100644 (file)
@@ -1975,16 +1975,18 @@ _PyUnicode_FindMaxChar(PyObject *unicode, Py_ssize_t start, Py_ssize_t end)
         return 127;
 
     kind = PyUnicode_KIND(unicode);
-    startptr = PyUnicode_DATA(unicode);
-    endptr = (char*)startptr + end * kind;
-    if (start)
-        startptr = (char*)startptr + start * kind;
-    switch(kind)
-    {
-    case PyUnicode_1BYTE_KIND: return ucs1lib_find_max_char(startptr, endptr);
-    case PyUnicode_2BYTE_KIND: return ucs2lib_find_max_char(startptr, endptr);
+    startptr = PyUnicode_DATA(unicode) + start * kind;
+    endptr = startptr + end * kind;
+    switch(kind) {
+    case PyUnicode_1BYTE_KIND:
+        return ucs1lib_find_max_char(startptr, endptr);
+    case PyUnicode_2BYTE_KIND:
+        return ucs2lib_find_max_char(startptr, endptr);
+    case PyUnicode_4BYTE_KIND:
+        return ucs4lib_find_max_char(startptr, endptr);
     default:
-    case PyUnicode_4BYTE_KIND: return ucs4lib_find_max_char(startptr, endptr);
+        assert(0);
+        return 0;
     }
 }