[arcmt] In GC, error for __strong/__weak on non-objc pointers.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@143887 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/ARCMigrate/TransGCAttrs.cpp b/lib/ARCMigrate/TransGCAttrs.cpp
index a85cad4d44acb877e0c52cf4ed10028c7e0ce814..79dc0538b69f84331748d1dd6a3aa56eb854307d 100644 (file)
--- a/lib/ARCMigrate/TransGCAttrs.cpp
+++ b/lib/ARCMigrate/TransGCAttrs.cpp
@@ -186,10 +186,28 @@ static void clearRedundantStrongs(MigrationContext &MigrateCtx) {
   }
 }
 
+static void errorForGCAttrsOnNonObjC(MigrationContext &MigrateCtx) {
+  TransformActions &TA = MigrateCtx.Pass.TA;
+
+  for (unsigned i = 0, e = MigrateCtx.GCAttrs.size(); i != e; ++i) {
+    MigrationContext::GCAttrOccurrence &Attr = MigrateCtx.GCAttrs[i];
+    if (Attr.FullyMigratable && Attr.Dcl) {
+      if (Attr.ModifiedType.isNull())
+        continue;
+      if (!Attr.ModifiedType->isObjCRetainableType()) {
+        TA.reportError("GC managed memory will become unmanaged in ARC",
+                       Attr.Loc);
+      }
+    }
+  }
+}
+
 void GCAttrsTraverser::traverseTU(MigrationContext &MigrateCtx) {
   GCAttrsCollector(MigrateCtx).TraverseDecl(
                                   MigrateCtx.Pass.Ctx.getTranslationUnitDecl());
+
   clearRedundantStrongs(MigrateCtx);
+  errorForGCAttrsOnNonObjC(MigrateCtx);
 }
 
 void MigrationContext::dumpGCAttrs() {

diff --git a/test/ARCMT/GC-check.m b/test/ARCMT/GC-check.m
index f71787ce029c3e8618e55d3f6d1351b6ad42db47..9864354228be00434af351d2b4d3abfb91c6cccb 100644 (file)
--- a/test/ARCMT/GC-check.m
+++ b/test/ARCMT/GC-check.m
@@ -12,3 +12,8 @@ void test1(CFTypeRef *cft) {
                 // expected-error {{unavailable}}
   NSAllocateCollectable(100, 0); // expected-error {{call returns pointer to GC managed memory; it will become unmanaged in ARC}}
 }
+
+@interface I1 {
+  __strong void *gcVar; // expected-error {{GC managed memory will become unmanaged in ARC}}
+}
+@end;

diff --git a/test/ARCMT/GC.h b/test/ARCMT/GC.h
index 6202e478c331236b7d4f3e5e28b2f0fd62efdf0a..4301baf272465a6f5e9f0c326d0e1f3669783600 100644 (file)
--- a/test/ARCMT/GC.h
+++ b/test/ARCMT/GC.h
@@ -1,5 +1,6 @@
 
 @interface ExtInterface {
   __strong ExtInterface *myivar;
+  __strong void *gcVar;
 }
 @end