]> granicus.if.org Git - clang/commitdiff
Do not warn about [super finalize] in arc mode.
authorNico Weber <nicolasweber@gmx.de>
Mon, 29 Aug 2011 22:59:14 +0000 (22:59 +0000)
committerNico Weber <nicolasweber@gmx.de>
Mon, 29 Aug 2011 22:59:14 +0000 (22:59 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@138776 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDeclObjC.cpp
test/SemaObjC/warn-missing-super.m

index 11bcb4f08304789c3d54b58e7b1273c06a6fe111..ef978f0730a1b398c962314b54e46507ce1fa0b2 100644 (file)
@@ -297,7 +297,9 @@ void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) {
       ObjCShouldCallSuperDealloc = 
         !Context.getLangOptions().ObjCAutoRefCount &&      
         MDecl->getMethodFamily() == OMF_dealloc;
-      ObjCShouldCallSuperFinalize = MDecl->getMethodFamily() == OMF_finalize;
+      ObjCShouldCallSuperFinalize =
+        !Context.getLangOptions().ObjCAutoRefCount &&      
+        MDecl->getMethodFamily() == OMF_finalize;
     }
   }
 }
index ff0c415872fc34628905f57cc256a360f44723fc..c25a6916620f1cc9db0186d89d53965251cdb7b1 100644 (file)
@@ -45,6 +45,5 @@
 // CHECK: 2 warnings generated.
 
 // RUN: %clang_cc1 -fsyntax-only -triple x86_64-apple-darwin10 -fobjc-nonfragile-abi -fobjc-arc %s 2>&1 | FileCheck --check-prefix=CHECK-ARC %s
-// CHECK-ARC: warn-missing-super.m:25:1: warning: method possibly missing a [super finalize] call
 // CHECK-ARC: warn-missing-super.m:35:4: error: ARC forbids explicit message send of 'dealloc'
-// CHECK-ARC: 1 warning and 1 error generated.
+// CHECK-ARC: 1 error generated.