]> granicus.if.org Git - zfs/commitdiff
Unconditionally build zdb and ztest with -DDEBUG
authorRichard Yao <ryao@gentoo.org>
Fri, 11 Dec 2015 23:40:05 +0000 (18:40 -0500)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 14 Dec 2015 20:53:09 +0000 (12:53 -0800)
Illumos unconditionally builds zdb and ztest with -DDEBUG. This helps
catch bugs and eliminates the need for commits like
202619623022722f30c2ee49931a4fa6896421c7, which changed ASSERTs to
VERIFYs. The following files in the illumos tree show this:

usr/src/cmd/zdb/Makefile.com
usr/src/cmd/ztest/Makefile.com

Given the usefulness of having early failure in these tools, we should
do it too.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #4095

cmd/zdb/Makefile.am
cmd/ztest/Makefile.am

index bc47cffbaa94616967b3847dcced479b537f9ae6..c22186a10f9699a8c30c4283f3b61202a8a1a285 100644 (file)
@@ -1,5 +1,7 @@
 include $(top_srcdir)/config/Rules.am
 
+AM_CPPFLAGS += -DDEBUG
+
 DEFAULT_INCLUDES += \
        -I$(top_srcdir)/include \
        -I$(top_srcdir)/lib/libspl/include
index ef4d99f288e8822fcc2d42f4d73251f05ec300cf..e3be39a0c26217a9f0d2ef7b8ad6cc8aae08fdc5 100644 (file)
@@ -1,6 +1,7 @@
 include $(top_srcdir)/config/Rules.am
 
 AM_CFLAGS += $(DEBUG_STACKFLAGS) $(FRAME_LARGER_THAN)
+AM_CPPFLAGS += -DDEBUG
 
 DEFAULT_INCLUDES += \
        -I$(top_srcdir)/include \