Simplify the code and remove dead code

Summary: Fix coverity cid 1374240

Reviewers: dberlin

Reviewed By: dberlin

Differential Revision: https://reviews.llvm.org/D31928

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299924 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Utils/PredicateInfo.cpp b/lib/Transforms/Utils/PredicateInfo.cpp
index aacbd59ca493ea44afa5b7b09506be27dc00f5b1..8877aeafecdec8ebbce57a989a4c0286dce6a7d0 100644 (file)
--- a/lib/Transforms/Utils/PredicateInfo.cpp
+++ b/lib/Transforms/Utils/PredicateInfo.cpp
@@ -210,11 +210,9 @@ struct ValueDFS_Compare {
     auto LookupResult = OBBMap.find(BB);
     if (LookupResult != OBBMap.end())
       return LookupResult->second->dominates(AInst, BInst);
-    else {
-      auto Result = OBBMap.insert({BB, make_unique<OrderedBasicBlock>(BB)});
-      return Result.first->second->dominates(AInst, BInst);
-    }
-    return std::tie(ADef, A.U) < std::tie(BDef, B.U);
+
+    auto Result = OBBMap.insert({BB, make_unique<OrderedBasicBlock>(BB)});
+    return Result.first->second->dominates(AInst, BInst);
   }
 };