MFB

oci_lob_save() should be removed indeed, but we're already in feature freeze =(

diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index 95d7e5f11f20b9e4d262c687c4213a4cbf0b16a4..669250180bd319163401b68277815b860d083a82 100644 (file)
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -3842,8 +3842,8 @@ PHP_FUNCTION(oci_lob_save)
 
                        if (offparam == -1) {
                                offset = curloblen;
-                       } else if ((ub4) offparam >= curloblen) {
-                               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Offset smaller than current LOB-Size - appending");
+                       } else if (offparam >= curloblen) {
+                               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Offset is bigger than current LOB-Size - appending");
                                offset = curloblen;
                        } else {
                                offset = offparam;
@@ -3852,7 +3852,6 @@ PHP_FUNCTION(oci_lob_save)
                        WRONG_PARAM_COUNT;
                }
 
-               offset++;
                convert_to_string_ex(arg);
                loblen = Z_STRLEN_PP(arg);