]> granicus.if.org Git - php/commitdiff
Fix leak in transliterator_transliterate()
authorNikita Popov <nikic@php.net>
Fri, 17 Apr 2015 07:56:48 +0000 (09:56 +0200)
committerNikita Popov <nikic@php.net>
Fri, 17 Apr 2015 08:33:58 +0000 (10:33 +0200)
ext/intl/transliterator/transliterator_methods.c

index d8b030a6d14eedfb47c7a10394a143f5c4096003..34f283b28179a6eb51d9ff39c8d1975735de2b22 100644 (file)
@@ -350,6 +350,7 @@ PHP_FUNCTION( transliterator_transliterate )
                                php_error_docref0( NULL, E_WARNING, "Could not create "
                                        "transliterator with ID \"%s\" (%s)", Z_STRVAL_P( arg1 ), message->val );
                                zend_string_free( message );
+                               ZVAL_UNDEF(&tmp_object);
                                /* don't set U_ILLEGAL_ARGUMENT_ERROR to allow fetching of inner error */
                                goto cleanup;
                        }
@@ -463,7 +464,7 @@ cleanup:
                RETVAL_FALSE;
        }
 
-       /* zval_ptr_dtor( &tmp_object ); */
+       zval_ptr_dtor( &tmp_object );
 }
 /* }}} */