Fix broken compare function for tsquery_ops. Per Tom's report.

I never understood why initial authors GiST in pgsql choose so
stgrange signature for 'same' method:
bool *sameFn(Datum a, Datum b, bool* result)
instead of simple, logical
bool sameFn(Datum a, Datum b)
This change will break any existing GiST extension, so we still live with
it and will live.

diff --git a/src/backend/utils/adt/tsquery_gist.c b/src/backend/utils/adt/tsquery_gist.c
index fdefd92bae244dbcc62a9a4cd8eec010b78aebdc..12b43c2c123aff45da6f7c1aab7cd7d74272c643 100644 (file)
--- a/src/backend/utils/adt/tsquery_gist.c
+++ b/src/backend/utils/adt/tsquery_gist.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/adt/tsquery_gist.c,v 1.4 2008/01/01 19:45:53 momjian Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/adt/tsquery_gist.c,v 1.4.2.1 2008/04/20 09:29:48 teodor Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -101,8 +101,11 @@ gtsquery_same(PG_FUNCTION_ARGS)
 {
        TSQuerySign *a = (TSQuerySign *) PG_GETARG_POINTER(0);
        TSQuerySign *b = (TSQuerySign *) PG_GETARG_POINTER(1);
+       bool            *result = (bool *) PG_GETARG_POINTER(2);
 
-       PG_RETURN_POINTER(*a == *b);
+       *result = (*a == *b) ? true : false;
+
+       PG_RETURN_POINTER(result);
 }
 
 static int