#18357: add tests for dictview set difference. Patch by Fraser Tweedale.

diff --git a/Lib/test/test_dictviews.py b/Lib/test/test_dictviews.py
index ac8bfe69e601c1b7a50dfe6129fbdc11b3cb8a70..7b02ea9eba318395dd55b6969517fe8f8116b39a 100644 (file)
--- a/Lib/test/test_dictviews.py
+++ b/Lib/test/test_dictviews.py
@@ -112,6 +112,13 @@ class DictSetTest(unittest.TestCase):
         self.assertEqual(d1.keys() ^ set(d3.keys()),
                          {'a', 'b', 'd', 'e'})
 
+        self.assertEqual(d1.keys() - d1.keys(), set())
+        self.assertEqual(d1.keys() - d2.keys(), {'a'})
+        self.assertEqual(d1.keys() - d3.keys(), {'a', 'b'})
+        self.assertEqual(d1.keys() - set(d1.keys()), set())
+        self.assertEqual(d1.keys() - set(d2.keys()), {'a'})
+        self.assertEqual(d1.keys() - set(d3.keys()), {'a', 'b'})
+
         self.assertFalse(d1.keys().isdisjoint(d1.keys()))
         self.assertFalse(d1.keys().isdisjoint(d2.keys()))
         self.assertFalse(d1.keys().isdisjoint(list(d2.keys())))
@@ -162,6 +169,13 @@ class DictSetTest(unittest.TestCase):
         self.assertEqual(d1.items() ^ d3.items(),
                          {('a', 1), ('b', 2), ('d', 4), ('e', 5)})
 
+        self.assertEqual(d1.items() - d1.items(), set())
+        self.assertEqual(d1.items() - d2.items(), {('a', 1)})
+        self.assertEqual(d1.items() - d3.items(), {('a', 1), ('b', 2)})
+        self.assertEqual(d1.items() - set(d1.items()), set())
+        self.assertEqual(d1.items() - set(d2.items()), {('a', 1)})
+        self.assertEqual(d1.items() - set(d3.items()), {('a', 1), ('b', 2)})
+
         self.assertFalse(d1.items().isdisjoint(d1.items()))
         self.assertFalse(d1.items().isdisjoint(d2.items()))
         self.assertFalse(d1.items().isdisjoint(list(d2.items())))

diff --git a/Misc/ACKS b/Misc/ACKS
index 2279417b7d74797982e25851ad54b7e6a6fe8d62..2d3b929f323aeca10d297c836a658dd8e6effb21 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1252,6 +1252,7 @@ David Turner
 Stephen Turner
 Theodore Turocy
 Bill Tutt
+Fraser Tweedale
 Doobee R. Tzeck
 Eren Türkay
 Lionel Ulmer

diff --git a/Misc/NEWS b/Misc/NEWS
index 2550dc48450a7e99a3f08392445ee49e4f6ce494..d6a645d8870dec262b870fcbf7d1d47cc49b2b4b 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -237,6 +237,9 @@ IDLE
 Tests
 -----
 
+- Issue #18357: add tests for dictview set difference.
+  Patch by Fraser Tweedale.
+
 - Issue #18273: move the tests in Lib/test/json_tests to Lib/test/test_json
   and make them discoverable by unittest.  Patch by Zachary Ware.