Fix minor thinko in convertToJsonb().

The amount of space to reserve for the value's varlena header is
VARHDRSZ, not sizeof(VARHDRSZ).  The latter coding accidentally
failed to fail because of the way the VARHDRSZ macro is currently
defined; but if we ever change it to return size_t (as one might
reasonably expect it to do), convertToJsonb() would have failed.

Spotted by Mark Dilger.

diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c
index 2ff85396d015cd4068720a57d6e30765d5e8c449..c62941baa7be77e7ee1ca6c36e39051e275478a8 100644 (file)
--- a/src/backend/utils/adt/jsonb_util.c
+++ b/src/backend/utils/adt/jsonb_util.c
@@ -1377,7 +1377,7 @@ convertToJsonb(JsonbValue *val)
        initStringInfo(&buffer);
 
        /* Make room for the varlena header */
-       reserveFromBuffer(&buffer, sizeof(VARHDRSZ));
+       reserveFromBuffer(&buffer, VARHDRSZ);
 
        convertJsonbValue(&buffer, &jentry, val, 0);