Issue #10571: Fix the "--sign" option of distutils' upload command.

Patch by Jakub Wilk.

diff --git a/Lib/distutils/command/upload.py b/Lib/distutils/command/upload.py
index 4926aa3e15439490887842647f70003c39892b4a..8b36851d25684a385a2f79c61e7e2d730e4bf4dc 100644 (file)
--- a/Lib/distutils/command/upload.py
+++ b/Lib/distutils/command/upload.py
@@ -125,7 +125,7 @@ class upload(PyPIRCCommand):
 
         if self.sign:
             data['gpg_signature'] = (os.path.basename(filename) + ".asc",
-                                     open(filename+".asc").read())
+                                     open(filename+".asc", "rb").read())
 
         # set up the authentication
         user_pass = (self.username + ":" + self.password).encode('ascii')

diff --git a/Misc/ACKS b/Misc/ACKS
index 514e95dbec941d5d84781f06a988bfa472c8be13..efa7339e2b3e7c1f67caa25194bc4da15e7d4912 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1009,6 +1009,7 @@ Felix Wiemann
 Gerry Wiener
 Frank Wierzbicki
 Bryce "Zooko" Wilcox-O'Hearn
+Jakub Wilk
 Jason Williams
 John Williams
 Sue Williams

diff --git a/Misc/NEWS b/Misc/NEWS
index a8c274965d9934f0ca19687d5f31145226f0c1cc..242b8f76d1a54d9ab540c51e10db5893123184e0 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -81,6 +81,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #10571: Fix the "--sign" option of distutils' upload command.
+  Patch by Jakub Wilk.
+
 - Issue #9559: If messages were only added, a new file is no longer
   created and renamed over the old file when flush() is called on an
   mbox, MMDF or Babyl mailbox.