Add test to ensure ReflectionClass works correctly with traits

Some of these were not working correctly before Guilherme's patch.
Another was broken by it and is fixed in this commit as well.

diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index 309b10c1bb17125445bd66181b43de1551a2651d..1f16c4da78b0c3cad8740b53977b166c4641967f 100644 (file)
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -4084,7 +4084,7 @@ ZEND_METHOD(reflection_class, isInstantiable)
                return;
        }
        GET_REFLECTION_OBJECT_PTR(ce);
-       if (ce->ce_flags & (ZEND_ACC_INTERFACE | ZEND_ACC_EXPLICIT_ABSTRACT_CLASS | ZEND_ACC_IMPLICIT_ABSTRACT_CLASS)) {
+       if (ce->ce_flags & (ZEND_ACC_INTERFACE | ZEND_ACC_TRAIT | ZEND_ACC_EXPLICIT_ABSTRACT_CLASS | ZEND_ACC_IMPLICIT_ABSTRACT_CLASS)) {
                RETURN_FALSE;
        }
 

diff --git a/ext/reflection/reflectionclass_for_traits.phpt b/ext/reflection/reflectionclass_for_traits.phpt
new file mode 100644 (file)
index 0000000..526310a
--- /dev/null
+++ b/ext/reflection/reflectionclass_for_traits.phpt
@@ -0,0 +1,20 @@
+--TEST--
+Tests some parts of ReflectionClass behavior for traits
+--FILE--
+<?php
+
+trait T {}
+
+$r = new ReflectionClass('T');
+var_dump(Reflection::getModifierNames($r->getModifiers()));
+var_dump($r->isAbstract());
+var_dump($r->isInstantiable());
+var_dump($r->isCloneable());
+
+?>
+--EXPECT--
+array(0) {
+}
+bool(false)
+bool(false)
+bool(false)