patch 8.0.0291: Visual block insertion does not insert in all lines

Problem:    Visual block insertion does not insert in all lines.
Solution:   Don't bail out of insert too early. Add a test. (Christian
            Brabandt, closes #1290)

diff --git a/src/ops.c b/src/ops.c
index 0a489126c034f96f9126a34e070a298c20ceaeea..1c0276d8d79de81363f0ddc211bd5fec893ad598 100644 (file)
--- a/src/ops.c
+++ b/src/ops.c
@@ -2571,8 +2571,7 @@ op_insert(oparg_T *oap, long count1)
     }
 
     t1 = oap->start;
-    if (edit(NUL, FALSE, (linenr_T)count1))
-       return;
+    (void)edit(NUL, FALSE, (linenr_T)count1);
 
     /* When a tab was inserted, and the characters in front of the tab
      * have been converted to a tab as well, the column of the cursor

diff --git a/src/testdir/test_visual.vim b/src/testdir/test_visual.vim
index d84a14062b2052d804a581eb14fa32af813c9a9d..8768395ba11be66b276e9337b09d5dc5707ae9ad 100644 (file)
--- a/src/testdir/test_visual.vim
+++ b/src/testdir/test_visual.vim
@@ -23,3 +23,16 @@ func Test_dotregister_paste()
   call assert_equal('hello world world', getline(1))
   q!
 endfunc
+
+func Test_Visual_ctrl_o()
+  new
+  call setline(1, ['one', 'two', 'three'])
+  call cursor(1,2)
+  set noshowmode
+  set tw=0
+  call feedkeys("\<c-v>jjlIa\<c-\>\<c-o>:set tw=88\<cr>\<esc>", 'tx')
+  call assert_equal(['oane', 'tawo', 'tahree'], getline(1, 3))
+  call assert_equal(88, &tw)
+  set tw&
+  bw!
+endfu

diff --git a/src/version.c b/src/version.c
index c1b998bdf9ea819a524e090777f8db2f1a574a62..3316a0a67f55d1d297d70d8c1d97d389209fbd35 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -764,6 +764,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    291,
 /**/
     290,
 /**/