2009-07-10 Hans Boehm <Hans.Boehm@hp.com>

	* finalize.c (GC_finalize_all): Always call GC_invoke_finalizers
	instead, following Ivan's original patch.

diff --git a/ChangeLog b/ChangeLog
index f3eaef2137d42159cb890dc6c0ddbc97e0de244a..0e335d8e23fc1117fbc918ee0838295c74429408 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-07-10  Hans Boehm <Hans.Boehm@hp.com>
+
+       * finalize.c (GC_finalize_all): Always call GC_invoke_finalizers
+       instead, following Ivan's original patch.
+
 2009-06-20  Hans Boehm <Hans.Boehm@hp.com>
        
        * allchblk.c (GC_allochblk_nth): Add assertion.

diff --git a/finalize.c b/finalize.c
index b77f5fdd930759f62073c1612ba2ee2ba4616d7d..4e6d56778425c4ab24fe0ac1a7b47ead3b7810de 100644 (file)
--- a/finalize.c
+++ b/finalize.c
@@ -716,12 +716,10 @@ GC_API void GC_CALL GC_finalize_all(void)
       GC_enqueue_all_finalizers();
       UNLOCK();
       GC_invoke_finalizers();
-      if (GC_finalize_on_demand &&
-          GC_finalizer_notifier != (GC_finalizer_notifier_proc)0) {
-       GC_finalizer_notifier();
-      } else {
-       GC_invoke_finalizers();
-      }
+      /* Running the finalizers in this thread is arguably not a good  */
+      /* idea when we should be notifying another thread to run them.  */
+      /* But otherwise we don't have a great way to wait for them to   */
+      /* run.                                                          */
       LOCK();
     }
     UNLOCK();