]> granicus.if.org Git - clang/commitdiff
[PlistSupport] Produce a newline to end plist output files
authorHubert Tong <hubert.reinterpretcast@gmail.com>
Mon, 10 Jun 2019 22:30:57 +0000 (22:30 +0000)
committerHubert Tong <hubert.reinterpretcast@gmail.com>
Mon, 10 Jun 2019 22:30:57 +0000 (22:30 +0000)
Summary:
As suggested in the review of D62949, this patch updates the plist
output to have a newline at the end of the file. This makes it so that
the plist output file qualifies as a POSIX text file, which increases
the consumability of the generated plist file in relation to various
tools.

Reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty

Reviewed By: NoQ, xingxue

Subscribers: jsji, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D63041

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@362992 91177308-0d34-0410-b5e6-96231b3b80d8

lib/ARCMigrate/PlistReporter.cpp
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

index 636caddf1bec034a8412047cb97e5a5f18ffc472..6d7fcb053b4828b7d5361010e03f3bfe50a9300c 100644 (file)
@@ -120,5 +120,5 @@ void arcmt::writeARCDiagsToPlist(const std::string &outPath,
   o << " </array>\n";
 
   // Finish.
-  o << "</dict>\n</plist>";
+  o << "</dict>\n</plist>\n";
 }
index 231db1fa16f68c5adea44e67ba2747f775f061bf..838751279297424d2d3e70d7a7c912428cac38dc 100644 (file)
@@ -748,7 +748,7 @@ void PlistDiagnostics::FlushDiagnosticsImpl(
   }
 
   // Finish.
-  o << "</dict>\n</plist>";
+  o << "</dict>\n</plist>\n";
 }
 
 //===----------------------------------------------------------------------===//