]> granicus.if.org Git - python/commitdiff
Clean up the warnings filter use in test_unicode.
authorBrett Cannon <bcannon@gmail.com>
Sat, 20 Mar 2010 22:22:22 +0000 (22:22 +0000)
committerBrett Cannon <bcannon@gmail.com>
Sat, 20 Mar 2010 22:22:22 +0000 (22:22 +0000)
Lib/test/test_unicode.py

index ef9aa9ea1472742314009b4391a4eb63e2aef684..1da2d1491cdc000b66f7785ff462854deedc1e04 100644 (file)
@@ -31,18 +31,11 @@ def search_function(encoding):
         return None
 codecs.register(search_function)
 
-class UnicodeTest(
-    string_tests.CommonTest,
-    string_tests.MixinStrUnicodeUserStringTest,
-    string_tests.MixinStrUnicodeTest,
-    ):
-    type2test = str
-
-    def setUp(self):
-        self.warning_filters = warnings.filters[:]
+class UnicodeTest(string_tests.CommonTest,
+        string_tests.MixinStrUnicodeUserStringTest,
+        string_tests.MixinStrUnicodeTest):
 
-    def tearDown(self):
-        warnings.filters = self.warning_filters
+    type2test = str
 
     def checkequalnofix(self, result, object, methodname, *args):
         method = getattr(object, methodname)
@@ -283,11 +276,12 @@ class UnicodeTest(
         self.assertRaises(TypeError, 'replace'.replace, "r", 42)
 
     def test_bytes_comparison(self):
-        warnings.simplefilter('ignore', BytesWarning)
-        self.assertEqual('abc' == b'abc', False)
-        self.assertEqual('abc' != b'abc', True)
-        self.assertEqual('abc' == bytearray(b'abc'), False)
-        self.assertEqual('abc' != bytearray(b'abc'), True)
+        with support.check_warnings():
+            warnings.simplefilter('ignore', BytesWarning)
+            self.assertEqual('abc' == b'abc', False)
+            self.assertEqual('abc' != b'abc', True)
+            self.assertEqual('abc' == bytearray(b'abc'), False)
+            self.assertEqual('abc' != bytearray(b'abc'), True)
 
     def test_comparison(self):
         # Comparisons: